Page MenuHomeFreeBSD

Framework: Introduce bsd.sponsor.mk
Needs ReviewPublic

Authored by arrowd on Mar 23 2024, 7:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 2:30 AM
Unknown Object (File)
Sat, May 4, 1:23 PM
Unknown Object (File)
Thu, May 2, 11:38 AM
Unknown Object (File)
Apr 26 2024, 8:25 AM
Unknown Object (File)
Apr 26 2024, 4:27 AM
Unknown Object (File)
Apr 25 2024, 6:20 PM
Unknown Object (File)
Apr 22 2024, 8:31 PM
Unknown Object (File)
Apr 19 2024, 4:34 AM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr
Summary

These changes add two framework-level make targets:

  • make sponsor pops out a dialog window listing available sponsorship options. Choosing one calls xdg-open or echo with corresponding URL
  • make sponsor-describe outputs sponsorship information in machine-readable format

Sponsorship info can be specified on the per-port basis, or in a common DB
file bsd.sponsor.db.mk

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 57156
Build 54044: arc lint + arc unit

Event Timeline

arrowd created this revision.
mat added inline comments.
Mk/bsd.sponsor.mk
39–40

This should probably be GH_PROJECT or something.

mat requested changes to this revision.Mar 24 2024, 7:54 AM
mat added a subscriber: bapt.

An interactive thing is nice and all, but we want users to stop using ports and use packages, so the sponsorship information should end up in the package's metadata, you should talk with @bapt to see how this could be done best.

This revision now requires changes to proceed.Mar 24 2024, 7:54 AM

we want users to stop using ports and use packages

Who "we"? I don't want that and will keep working in the direction I deem useful.

the sponsorship information should end up in the package's metadata

I agree, but for now it can be queried from the port with make sponsor-describe. AFAIK, freshports.org queries ports for data, not packages.

arrowd marked an inline comment as done.
  • Use GH_ACCOUNT

we want users to stop using ports and use packages

Who "we"? I don't want that and will keep working in the direction I deem useful.

We is portmgr as a whole.
I don't mind you making things work for ports when it is broken, but we want to move forward, not backwards.
So, features need to be available in packages before they are of any use in ports.

  • Put sponsorship information into the resulting package via PKG_NOTES
Mk/bsd.sponsor.db.mk
9–10

I hope that there will be more than just you before this gets committed.
Otherwise, it feels like you are adding a feature just to ask for money.

Mk/bsd.sponsor.db.mk
9–10

I also added sponsor options for ftp/curl upstream as an example. What else should I add?

  • Add Patreon and Opencollective sites
  • databases/sqlitebrowser: Add sponsorship information
  • textproc/logseq: Add sponsorship information