Page MenuHomeFreeBSD
Differential D43619

autodeps: determine dependencies automatically
Needs ReviewPublic
Actions

Authored by bapt on Jan 26 2024, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 4:57 PM
Unknown Object (File)
Fri, Apr 26, 3:10 AM
Unknown Object (File)
Mon, Apr 15, 3:12 PM
Unknown Object (File)
Mon, Apr 15, 2:44 PM
Unknown Object (File)
Mon, Apr 15, 1:42 PM
Unknown Object (File)
Mon, Apr 15, 1:29 PM
Unknown Object (File)
Mon, Apr 15, 1:09 PM
Unknown Object (File)
Mon, Apr 15, 12:57 PM
View All 16 Files
Subscribers
arrowd
mat

Details

Reviewers
mat
Group Reviewers
portmgr
Summary

The goal is to kill the translation from LIB_DEPENDS to RUN_DEPENDS
which simplifies dependencies declaration

This method can be extended to automatically catch shebangs as well

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57049
Build 53937: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Jan 26 2024, 4:52 PM
bapt created this revision.
Harbormaster completed remote builds in B55645: Diff 133409.Jan 26 2024, 4:52 PM
bapt updated this revision to Diff 133415.Jan 26 2024, 6:39 PM

fix LIB_DEPENDS now

Harbormaster completed remote builds in B55648: Diff 133415.Jan 26 2024, 6:39 PM
arrowd added a subscriber: arrowd.Thu, Apr 11, 4:45 PM
arrowd added inline comments.
Mk/Scripts/autodeps.sh
26

In Mk/Uses/electronfix.mk I'm using the following incantation to find linux binaries:

${FIND} ${STAGEDIR}${DATADIR} -type f -exec brandelf {} ';' 2> /dev/null | grep -v "'FreeBSD' (9)"

In you case you can just reverse the check.

bapt updated this revision to Diff 136922.Fri, Apr 12, 8:04 AM

pet shellcheck and @arrowd comment

Harbormaster completed remote builds in B57046: Diff 136922.Fri, Apr 12, 8:04 AM
bapt added a reviewer: portmgr.Fri, Apr 12, 8:04 AM
bapt marked an inline comment as done.
mat accepted this revision.Fri, Apr 12, 8:07 AM
mat added a subscriber: mat.

Looks ok to me

This revision is now accepted and ready to land.Fri, Apr 12, 8:07 AM
bapt updated this revision to Diff 136928.Fri, Apr 12, 9:46 AM

forgot STAGEDIR in this version

This revision now requires review to proceed.Fri, Apr 12, 9:46 AM
Harbormaster completed remote builds in B57047: Diff 136928.Fri, Apr 12, 9:46 AM
bapt updated this revision to Diff 136929.Fri, Apr 12, 10:14 AM

deal with keywords

Harbormaster completed remote builds in B57048: Diff 136929.Fri, Apr 12, 10:14 AM
bapt updated this revision to Diff 136930.Fri, Apr 12, 10:34 AM

remove debug

Harbormaster completed remote builds in B57049: Diff 136930.Fri, Apr 12, 10:36 AM
arrowd added inline comments.Sat, Apr 13, 11:08 AM
Mk/Scripts/autodeps.sh
34

Debugging leftovers?

bapt marked an inline comment as done.Sat, Apr 13, 1:42 PM

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
45 lines
1 line
21 lines

Diff 136930

View Options

Mk/Scripts/autodeps.sh

Loading...
View Options

Mk/Scripts/create-manifest.sh

Loading...
View Options

Mk/bsd.port.mk

Loading...