Differential D37882

QCOM: various bits
AbandonedPublic
Actions

Authored by bz on Dec 27 2022, 10:41 AM.

Tags

None

Referenced Files

	F175240241: D37882.id114570.diff
	Fri, Oct 9, 8:48 AM

	F175234674: D37882.id114570.diff
	Fri, Oct 9, 7:47 AM

	Unknown Object (File)
	Tue, Oct 6, 4:15 AM

	Unknown Object (File)
	Sun, Sep 27, 9:34 PM

	Unknown Object (File)
	Sat, Sep 26, 10:18 PM

	Unknown Object (File)
	Fri, Sep 25, 5:31 AM

	Unknown Object (File)
	Thu, Sep 24, 10:48 PM

	Unknown Object (File)
	Thu, Sep 24, 6:04 AM

Subscribers

Details

Reviewers

adrian
manu
andrew

Summary

NOT INTENDED TO BE COMMITTED LIKE THIS.

add files to the build so they are (a) usable and (b) do not rot by not getting compiled
fix an insta-panic in qcom_mdio_ipq4018 due to a missing bus function.
cleanup the qcom_rnd some in order to move forward for more support, less racyness and less panicing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48891
Build 45780: arc lint + arc unit

Event Timeline

bz created this revision.Dec 27 2022, 10:41 AM

Herald added a reviewer: manu. · View Herald TranscriptDec 27 2022, 10:41 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

bz requested review of this revision.Dec 27 2022, 10:41 AM

Harbormaster completed remote builds in B48891: Diff 114570.Dec 27 2022, 10:41 AM

Just put this up so I won't lose it. The qcom_mdio_ipq4018.c 1-line change could probably go in along with adding that file to the build.

Thanks for the cleanup!

bz mentioned this in rGbfed2417f472: qcom: fix panic in qcom_mdio_ipq4018 implementation.Aug 11 2023, 2:13 AM

The panic was fixed in bfed2417f472f87e720b37bdac9ffd75ca2abc54 ; the remainder I don't care anymore.

Herald added a reviewer: andrew. · View Herald TranscriptFri, Sep 18, 12:20 AM

Herald added a reviewer: andrew. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

arm64/

conf/

2 lines

conf/

2 lines

dev/

qcom_mdio/

qcom_mdio_ipq4018.c

3 lines

qcom_rnd/

211 lines

Diff 114570

sys/arm64/conf/std.qcom

Loading...

sys/conf/files.arm64

Loading...

sys/dev/qcom_mdio/qcom_mdio_ipq4018.c

Loading...

sys/dev/qcom_rnd/qcom_rnd.c

Loading...