Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 12:08 PM

	Unknown Object (File)
	Wed, Apr 24, 12:08 PM

	Unknown Object (File)
	Sun, Apr 21, 8:21 PM

	Unknown Object (File)
	Sun, Apr 21, 8:10 PM

	Unknown Object (File)
	Dec 20 2023, 6:15 AM

	Unknown Object (File)
	Dec 12 2023, 12:46 PM

	Unknown Object (File)
	Nov 26 2023, 9:45 PM

	Unknown Object (File)
	Nov 19 2023, 4:46 PM

Subscribers

Details

Reviewers

jhb
corvink

Group Reviewers

bhyve

Commits

rG385e330c1c5d: bhyve: Drop volatile qualifiers from snapshot code
rG8b1adff8bcbd: bhyve: Drop volatile qualifiers from snapshot code

Summary

They accomplish nothing since the qualifier is casted away in calls to
memcpy() and copyin()/copyout(). No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 6 2022, 7:36 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptNov 6 2022, 7:36 PM

markj requested review of this revision.Nov 6 2022, 7:36 PM

markj added a parent revision: D37291: bhyve: Drop volatile qualifiers from virtio rings.

Harbormaster completed remote builds in B48196: Diff 112700.Nov 6 2022, 7:36 PM

markj added a child revision: D37293: bhyve: Cast away const when fetching a config nvlist.Nov 6 2022, 7:37 PM

corvink accepted this revision.Nov 7 2022, 8:15 AM

This revision is now accepted and ready to land.Nov 7 2022, 8:15 AM

jhb accepted this revision.Nov 9 2022, 7:10 PM

Closed by commit rG8b1adff8bcbd: bhyve: Drop volatile qualifiers from snapshot code (authored by markj). · Explain WhyNov 11 2022, 3:05 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG8b1adff8bcbd: bhyve: Drop volatile qualifiers from snapshot code.

markj added a commit: rG385e330c1c5d: bhyve: Drop volatile qualifiers from snapshot code.Nov 29 2022, 5:40 PM

bhyve: Drop volatile qualifiers from snapshot code
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 112937

sys/amd64/include/vmm_snapshot.h

sys/amd64/vmm/vmm_snapshot.c

usr.sbin/bhyve/snapshot.c

bhyve: Drop volatile qualifiers from snapshot codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 112937

sys/amd64/include/vmm_snapshot.h

sys/amd64/vmm/vmm_snapshot.c

usr.sbin/bhyve/snapshot.c

bhyve: Drop volatile qualifiers from snapshot code
ClosedPublic
Actions

Revision Contents
Changeset List