Page MenuHomeFreeBSD

bhyve: Drop volatile qualifiers from xhci hw struct fields
ClosedPublic

Authored by markj on Nov 6 2022, 7:36 PM.
Tags
None
Referenced Files
F161431109: D37290.diff
Fri, Jul 3, 4:39 PM
F161389636: D37290.id.diff
Fri, Jul 3, 8:37 AM
Unknown Object (File)
Sun, Jun 21, 1:17 PM
Unknown Object (File)
Sat, Jun 13, 9:12 AM
Unknown Object (File)
Wed, Jun 10, 6:31 AM
Unknown Object (File)
May 24 2026, 7:20 PM
Unknown Object (File)
May 24 2026, 7:15 PM
Unknown Object (File)
May 20 2026, 5:24 AM
Subscribers

Details

Summary

This fixes a warning raised by the removal of the volatile qualifier
from &trb->qwTrb0 in the following snippet:

xfer_block = usb_data_xfer_append(xfer,

	     (void *)(trbflags & XHCI_TRB_3_IDT_BIT ?
		 &trb->qwTrb0 : XHCI_GADDR(sc, trb->qwTrb0)),
	     trb->dwTrb2 & 0x1FFFF, (void *)addr, ccs);

The use of volatile appears to be inherited from the kernel driver's
definitions of the same structures. It makes some sense, since USB TRBs
and related structures live in guest memory, but bhyve device models
generally don't volatile-qualify accesses to guest memory and I can't
see how they are required for correctness here. Moreover, XHCI_GADDR
does not return volatile pointers so we're already being inconsistent.
So just drop the qualifiers to address the warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable