Page MenuHomeFreeBSD

amd64 pmap: two trivial changes
ClosedPublic

Authored by kib on Oct 10 2022, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 27 2024, 1:50 AM
Unknown Object (File)
Apr 24 2024, 5:19 AM
Unknown Object (File)
Apr 20 2024, 3:15 AM
Unknown Object (File)
Apr 19 2024, 1:57 PM
Unknown Object (File)
Apr 19 2024, 1:48 PM
Unknown Object (File)
Dec 20 2023, 8:27 AM
Unknown Object (File)
Dec 7 2023, 4:57 PM
Unknown Object (File)
Dec 4 2023, 2:19 AM
Subscribers

Details

Summary
add comment explaining why INVLPG is functional for PCID config
remove useless addr2 variables in page range invalidation handlers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Oct 10 2022, 12:40 AM
This revision is now accepted and ready to land.Oct 10 2022, 1:51 PM
sys/amd64/amd64/pmap.c
2909–2913

I would suggest:

"When PCID is enabled, the INVLPG instruction invalidates all TLB entries for the given page that either match the current PCID or are global. Since TLB entries for the same page under different PCIDs are unaffected, kernel pages which reside in all address spaces could be problematic. We avoid ...

kib marked an inline comment as done.

Alan' wording

This revision now requires review to proceed.Oct 10 2022, 8:42 PM
This revision is now accepted and ready to land.Oct 10 2022, 9:30 PM