sdp: garbage collect sdp_ctlinput

[glebius]

Summary

A pr_ctlinput method was a feature of IPv4/IPv6 with exeception of
pfctlinput(), which broadcasted a call to pr_ctlinput on all protocols
ever registered statically or with pf_proto_register(). Now that
this broadcast call is gone, the only protocols that get their
pr_ctlinput ever called are those that have registered itselves with
ipproto_register() or ip6proto_register().

It is entirely possible that code deleted now was dead code from very
beginning. Just a copy-paste from TCP.

[markj]

Can we just get rid of SDP now? I think OneFS was the last major user, but it has switched away from IB. The SDP implementation was pretty fragile when I worked on it and it hasn't been changed much since. OneFS had a number of local patches for it.

Maybe @vangyzen @rstone or @bdrewery can comment on whether it's ok to remove?

[glebius]

In D36208#822118, @markj wrote:

Can we just get rid of SDP now? I think OneFS was the last major user, but it has switched away from IB. The SDP implementation was pretty fragile when I worked on it and it hasn't been changed much since. OneFS had a number of local patches for it.

Maybe @vangyzen @rstone or @bdrewery can comment on whether it's ok to remove?

Meanwhile I would consider it as "Reviewed" for removing its pr_ctlinput :)

[rstone]

In D36208#822118, @markj wrote:

Can we just get rid of SDP now? I think OneFS was the last major user, but it has switched away from IB.

IB and SDP remain alive and well in OneFS, I'm afraid.