stand/zfs: Limit flags further for ZFS
ClosedPublic
Actions

Authored by imp on Jul 24 2022, 3:25 AM.

Details

Reviewers

manu
jrtc27
jhb
tsoome
allanjude
kevans

Commits

rG09ace5cefbd2: stand/zfs: Limit flags further for ZFS

Summary

Constrain CFLAGS for ZFS: don't add anything globally. Add the includes
to only the files that need them. Add -DHAS_ZSTD_ZFS to zfs.c (which
includes zfsimpl.c which includes zfssubr.c both of which need this
defined). Also add it to efi/boot1/Makefile since zfs_module.c also
includes zfsimple.c.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 24 2022, 3:25 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 24 2022, 3:25 AM

Herald added subscribers: dab, bcran, delphij. · View Herald Transcript

imp requested review of this revision.Jul 24 2022, 3:25 AM

Harbormaster completed remote builds in B46517: Diff 108443.Jul 24 2022, 3:25 AM

imp edited the test plan for this revision. (Show Details)Jul 24 2022, 3:28 AM

imp added reviewers: jrtc27, jhb, tsoome, allanjude.

Remove the non-libsa changes... If these defines are needed, I'll add them in a
subsequent commit. These changes don't change the CFLAGS for these directories.

Harbormaster completed remote builds in B46518: Diff 108444.Jul 24 2022, 4:19 AM

imp edited the test plan for this revision. (Show Details)Jul 24 2022, 4:19 AM

tsoome accepted this revision.Jul 24 2022, 7:29 AM

This revision is now accepted and ready to land.Jul 24 2022, 7:29 AM

Turns out, only zfs.c needs the cddl directory. Note to self... we may want to
move that under /stand for better grepping, etc since it's only used for the
bootloader (and now/soon makefs) so some thought is needed.

This revision now requires review to proceed.Jul 24 2022, 4:51 PM

Harbormaster completed remote builds in B46525: Diff 108462.Jul 24 2022, 4:51 PM

tsoome accepted this revision.Jul 24 2022, 5:03 PM

This revision is now accepted and ready to land.Jul 24 2022, 5:03 PM

imp added a reviewer: kevans.Jul 24 2022, 5:50 PM

Closed by commit rG09ace5cefbd2: stand/zfs: Limit flags further for ZFS (authored by imp). · Explain WhyJul 24 2022, 10:56 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG09ace5cefbd2: stand/zfs: Limit flags further for ZFS.