rip6: Fix a lock order reversal in rip6_bind()
ClosedPublic
Actions

Authored by markj on Jun 13 2022, 3:56 PM.

Details

Reviewers

glebius
mjg

Group Reviewers

network

Commits

rGa14465e1b9a5: rip6: Fix a lock order reversal in rip6_bind()

Summary

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45957
Build 42845: arc lint + arc unit

Event Timeline

markj created this revision.Jun 13 2022, 3:56 PM

Herald added subscribers: melifaro, bz, ae, imp. · View Herald TranscriptJun 13 2022, 3:56 PM

markj requested review of this revision.Jun 13 2022, 3:56 PM

Harbormaster completed remote builds in B45957: Diff 106866.Jun 13 2022, 3:56 PM

The patch of course brings locking into correct order. However, at a glance I don't see any good reason to lock INP_INFO_WLOCK() for this assignment on a single inp->inp6p_laddr. Maybe this is some feature of IPv6, that I don't know, though.

This revision is now accepted and ready to land.Jun 13 2022, 6:28 PM

In D35472#804439, @glebius wrote:

The patch of course brings locking into correct order. However, at a glance I don't see any good reason to lock INP_INFO_WLOCK() for this assignment on a single inp->inp6p_laddr. Maybe this is some feature of IPv6, that I don't know, though.

I wondered the same thing. rip6_connect() has the same "feature." I am inclined to leave it alone for now.

Closed by commit rGa14465e1b9a5: rip6: Fix a lock order reversal in rip6_bind() (authored by markj). · Explain WhyJun 14 2022, 4:02 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa14465e1b9a5: rip6: Fix a lock order reversal in rip6_bind().