HomeFreeBSD

pipe: Use a distinct wait channel for I/O serialization

Description

pipe: Use a distinct wait channel for I/O serialization

Suppose a thread tries to read from an empty pipe. pipe_read() does the
following:

  1. pipelock(), possibly sleeping
  2. check for buffered data
  3. pipeunlock()
  4. set PIPE_WANTR and sleep
  5. goto 1

pipelock() is an open-coded mutex; if a thread blocks in pipelock(), it
sleeps until the lock holder calls pipeunlock().

Both sleeps use the same wait channel. So if there are multiple threads
in pipe_read(), a thread T1 in step 3 can wake up a thread T2 sleeping
in step 4. Then T1 goes to sleep in step 4, and T2 acquires and
releases the pipelock, waking up T1 again. This can go on indefinitely,
livelocking the process (and potentially starving a would-be writer).

Fix the problem by using a separate wait channel for pipelock().

Reported by: Paul Floyd <paulf2718@gmail.com>
Reviewed by: mjg, kib
PR: 264441
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D35415

Details

Provenance
markjAuthored on Jun 14 2022, 2:52 PM
Reviewer
mjg
Differential Revision
D35415: pipe: Use a distinct wait channel for I/O serialization
Parents
rG116679b39cb9: rc.d/wpa_supplicant: Remove the sleep to improve boot time
Branches
Unknown
Tags
Unknown