Page MenuHomeFreeBSD

makefs(8): Fix calculation of metadata segmets sizes
ClosedPublic

Authored by mindal_semihalf.com on Thu, May 5, 12:49 PM.

Details

Summary
  • Remove "ncg" variable. It's always 1 and it was used to multiply stuff.

Adjust size calculations to match what is done in ffs_mkfs routine:

  • Depending on the UFS version the superblock is stored at a different offset. Take that into account.
  • Add the cylinder group block size.
  • All of the above has to be aligned to the block size.

PR: 229929 (partially)

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Calculations and comment are accurate.

This revision is now accepted and ready to land.Sat, May 14, 7:08 PM
This revision was automatically updated to reflect the committed changes.