libmd: symbol versioning
Needs ReviewPublic
Actions

Authored by kevans on Mar 9 2022, 3:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 5, 1:32 PM

	Unknown Object (File)
	Sun, Sep 1, 1:26 PM

	Unknown Object (File)
	Thu, Aug 22, 6:03 AM

	Unknown Object (File)
	Thu, Aug 22, 6:01 AM

	Unknown Object (File)
	Thu, Aug 22, 5:21 AM

	Unknown Object (File)
	Thu, Aug 15, 7:42 AM

	Unknown Object (File)
	Thu, Aug 15, 7:42 AM

	Unknown Object (File)
	Thu, Aug 15, 5:07 AM

View All 28 Files

Subscribers

delphij

imp

Details

Reviewers

andrew
jrtc27
emaste
allanjude

Summary

The primary benefit sought is exporting _libmd_* symbols in a private
namespace, and avoiding export of some other implementation details that
are shared amongst TUs.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44713
Build 41601: arc lint + arc unit

Event Timeline

kevans created this revision.Mar 9 2022, 3:35 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 9 2022, 3:35 AM

kevans requested review of this revision.Mar 9 2022, 3:35 AM

Harbormaster completed remote builds in B44713: Diff 103665.Mar 9 2022, 3:35 AM

kevans added a parent revision: D34498: libmd: stop exporting _block symbols.Mar 9 2022, 3:35 AM

kevans added a child revision: D34500: libmd: split tests out into the test infrastructure.

fuz mentioned this in D45444: lib/libmd: rework and accelerate SHA1 implementation.Jun 17 2024, 8:44 AM

Could you please remove these _version symbols? They are not supposed to be used by consumers and should be made static or commented out in the source files.