Page MenuHomeFreeBSD

Remove more quotes around Makefile .error/.warn/.info strings.
ClosedPublic

Authored by jhb on Feb 4 2022, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 3:15 AM
Unknown Object (File)
Wed, Oct 15, 12:27 PM
Unknown Object (File)
Wed, Oct 15, 12:27 PM
Unknown Object (File)
Wed, Oct 15, 12:27 PM
Unknown Object (File)
Wed, Oct 15, 1:28 AM
Unknown Object (File)
Sat, Oct 11, 8:00 PM
Unknown Object (File)
Thu, Oct 2, 7:43 PM
Unknown Object (File)
Tue, Sep 30, 1:25 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 4 2022, 8:56 PM

I thought we'd already done this.

share/mk/netbsd-tests.test.mk
9

Does this need $$? It was there before, but do you want to suggest it in terms of SRCTOP (in which case the syntax is wrong for some shells) or with the current value of srctop?

This revision is now accepted and ready to land.Feb 4 2022, 9:01 PM

Apparently I missed some, I might have just grepped Makefiles

share/mk/bsd.dep.mk
205–206

We can remove the space before \

share/mk/netbsd-tests.test.mk
9

My guess is that we want it to be emitted as a literal ${SRCTOP} not expanded, in that the person who encounters this error should set TESTSRC=${SRCTOP}/... in their Makefile.

jhb marked an inline comment as done.Feb 5 2022, 12:01 AM
jhb added inline comments.
share/mk/netbsd-tests.test.mk
9

Yeah, I think what Ed said.