Differential D33694

bus_dma: Deduplicate locking helper functions.
ClosedPublic
Actions

Authored by jhb on Dec 30 2021, 12:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 6:17 PM

	Unknown Object (File)
	Thu, Nov 6, 1:59 AM

	Unknown Object (File)
	Fri, Oct 31, 12:59 PM

	Unknown Object (File)
	Oct 21 2025, 5:54 PM

	Unknown Object (File)
	Oct 20 2025, 2:50 PM

	Unknown Object (File)
	Oct 20 2025, 2:50 PM

	Unknown Object (File)
	Oct 20 2025, 2:50 PM

	Unknown Object (File)
	Oct 20 2025, 1:04 AM

View All 100 Files

Subscribers

Details

Reviewers

imp
scottl
kib
manu

Commits

rG7def1e10b3cc: bus_dma: Deduplicate locking helper functions.

Summary

Move busdma_lock_mutex to subr_bus_dma.c.

Move _busdma_lock_dflt to subr_bus_dma.c. This function was named a couple of different things previously. It is not a public API but an internal helper used in place of a NULL pointer. The prototype is in <sys/bus_dma.h> as not all backends include <sys/bus_dma_internal.h>.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 30 2021, 12:40 AM

Herald added a reviewer: manu. · View Herald TranscriptDec 30 2021, 12:40 AM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

jhb requested review of this revision.Dec 30 2021, 12:40 AM

Harbormaster completed remote builds in B43643: Diff 100739.Dec 30 2021, 12:40 AM

kib accepted this revision.Jan 1 2022, 1:40 AM

kib added inline comments.

sys/sys/bus_dma.h
157	I think this blank line is extra.

This revision is now accepted and ready to land.Jan 1 2022, 1:40 AM

jhb marked an inline comment as done.Jan 4 2022, 10:52 PM

Closed by commit rG7def1e10b3cc: bus_dma: Deduplicate locking helper functions. (authored by jhb). · Explain WhyJan 5 2022, 9:52 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7def1e10b3cc: bus_dma: Deduplicate locking helper functions..

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

busdma_machdep.c

37 lines

arm64/

arm64/

busdma_machdep.c

37 lines

include/

1 line

kern/

39 lines

powerpc/

powerpc/

busdma_machdep.c

36 lines

riscv/

include/

1 line

riscv/

busdma_machdep.c

37 lines

sys/

5 lines

x86/

include/

1 line

x86/

busdma_machdep.c

37 lines

Diff 101014

sys/arm/arm/busdma_machdep.c

Loading...

sys/arm64/arm64/busdma_machdep.c

Loading...

sys/arm64/include/bus_dma_impl.h

Loading...

sys/kern/subr_bus_dma.c

Loading...

sys/powerpc/powerpc/busdma_machdep.c

Loading...

sys/riscv/include/bus_dma_impl.h

Loading...

sys/riscv/riscv/busdma_machdep.c

Loading...

sys/sys/bus_dma.h

Loading...

sys/x86/include/busdma_impl.h

Loading...

sys/x86/x86/busdma_machdep.c

Loading...