inpcb: use epoch protection when doing prison checks
ClosedPublic
Actions

Authored by glebius on Dec 8 2021, 6:43 PM.

Details

Reviewers

markj
bz
jamie

Group Reviewers

network

Commits

rG185e659c40ef: inpcb: use locked variant of prison_check_ip*()

Summary

The pcb lookup always happens in the network epoch and in SMR section.
We can't block on a mutex due to the latter. Now that prison address
lists are protected by the network epoch, use the locked variant of KPI.

Fixes: de2d47842e8

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Dec 8 2021, 6:43 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptDec 8 2021, 6:43 PM

glebius requested review of this revision.Dec 8 2021, 6:43 PM

Harbormaster completed remote builds in B43240: Diff 99722.Dec 8 2021, 6:43 PM

glebius added a parent revision: D33339: jail: network epoch protection for IP address lists.Dec 8 2021, 6:43 PM

markj accepted this revision.Dec 8 2021, 9:25 PM

This revision is now accepted and ready to land.Dec 8 2021, 9:25 PM

bz added a reviewer: jamie.Dec 8 2021, 10:11 PM

pi added a subscriber: pi.Dec 13 2021, 7:05 PM

I take it this is for what we're seeing in Bug 260335.

Closed by commit rG185e659c40ef: inpcb: use locked variant of prison_check_ip*() (authored by glebius). · Explain WhyDec 14 2021, 5:39 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG185e659c40ef: inpcb: use locked variant of prison_check_ip*().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

4 lines

netinet6/

in6_pcb.c

4 lines

Diff 100011

View Options

sys/netinet/in_pcb.c