Page MenuHomeFreeBSD
Differential D33286

nvd: For AHCI attached devices, report ahci bridge
ClosedPublic
Actions

Authored by imp on Dec 6 2021, 6:01 AM.
Tags
None
Referenced Files
F139619824: D33286.diff
Sun, Dec 14, 5:58 AM
Unknown Object (File)
Wed, Dec 10, 10:57 PM
Unknown Object (File)
Sun, Dec 7, 2:05 PM
Unknown Object (File)
Fri, Nov 28, 9:42 AM
Unknown Object (File)
Sat, Nov 22, 9:12 PM
Unknown Object (File)
Sat, Nov 22, 1:52 AM
Unknown Object (File)
Sat, Nov 22, 1:49 AM
Unknown Object (File)
Sat, Nov 22, 1:47 AM
View All Files
Subscribers
dab

Details

Reviewers
mav
chuck
ambrisko
adrian
Commits
rG67873a4fcabf: nvd: For AHCI attached devices, report ahci bridge
rGb8194f376667: nvd: For AHCI attached devices, report ahci bridge
Summary

When an NVME device is attached via a AHCI controller, we have no access
to its config space. So instead of information about the nvme drive
itself, return info about the AHCI controller as the next best thing.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43170
Build 40058: arc lint + arc unit

Event Timeline

imp created this revision.Dec 6 2021, 6:01 AM
Herald added a subscriber: dab. · View Herald TranscriptDec 6 2021, 6:01 AM
imp requested review of this revision.Dec 6 2021, 6:01 AM
imp added a parent revision: D33285: nvme_ahci: Mark AHCI devices as such in the controller.
Harbormaster completed remote builds in B43170: Diff 99516.Dec 6 2021, 6:01 AM
imp added a child revision: D33287: nvme_sim: Only report PCI related stats when we can.Dec 6 2021, 6:01 AM
imp added reviewers: mav, chuck, ambrisko.Dec 6 2021, 6:03 AM
imp added a reviewer: adrian.Dec 6 2021, 6:25 AM
mav accepted this revision.Dec 6 2021, 2:54 PM

I suppose RAID BIOS identification, which are these d_hba_* fields are used for, should indeed be based on the AHCI in this case.

This revision is now accepted and ready to land.Dec 6 2021, 2:54 PM
Closed by commit rGb8194f376667: nvd: For AHCI attached devices, report ahci bridge (authored by imp). · Explain WhyDec 6 2021, 5:26 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGb8194f376667: nvd: For AHCI attached devices, report ahci bridge.
mav added a commit: rG67873a4fcabf: nvd: For AHCI attached devices, report ahci bridge.Jan 21 2022, 6:50 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
nvd/
7 lines

Diff 99516

View Options

sys/dev/nvd/nvd.c

Loading...