nvd: For AHCI attached devices, report ahci bridge
ClosedPublic
Actions

Authored by imp on Dec 6 2021, 6:01 AM.

Details

Reviewers

mav
chuck
ambrisko
adrian

Commits

rG67873a4fcabf: nvd: For AHCI attached devices, report ahci bridge
rGb8194f376667: nvd: For AHCI attached devices, report ahci bridge

Summary

When an NVME device is attached via a AHCI controller, we have no access
to its config space. So instead of information about the nvme drive
itself, return info about the AHCI controller as the next best thing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Dec 6 2021, 6:01 AM

Herald added a subscriber: dab. · View Herald TranscriptDec 6 2021, 6:01 AM

imp requested review of this revision.Dec 6 2021, 6:01 AM

imp added a parent revision: D33285: nvme_ahci: Mark AHCI devices as such in the controller.

Harbormaster completed remote builds in B43170: Diff 99516.Dec 6 2021, 6:01 AM

imp added a child revision: D33287: nvme_sim: Only report PCI related stats when we can.Dec 6 2021, 6:01 AM

imp added reviewers: mav, chuck, ambrisko.Dec 6 2021, 6:03 AM

imp added a reviewer: adrian.Dec 6 2021, 6:25 AM

I suppose RAID BIOS identification, which are these d_hba_* fields are used for, should indeed be based on the AHCI in this case.

This revision is now accepted and ready to land.Dec 6 2021, 2:54 PM

Closed by commit rGb8194f376667: nvd: For AHCI attached devices, report ahci bridge (authored by imp). · Explain WhyDec 6 2021, 5:26 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGb8194f376667: nvd: For AHCI attached devices, report ahci bridge.

mav added a commit: rG67873a4fcabf: nvd: For AHCI attached devices, report ahci bridge.Jan 21 2022, 6:50 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvd/

nvd.c

7 lines

Diff 99574

View Options

nvd: For AHCI attached devices, report ahci bridgeClosedPublicActions