Page MenuHomeFreeBSD

pf: add COMPAT_FREEBSD12 for DIOCKEEPCOUNTERS
ClosedPublic

Authored by kp on Nov 15 2021, 9:17 PM.

Details

Summary

DIOCKEEPCOUNTERS used to overlap with DIOCGIFSPEEDV0, which has been
fixed in 14, but remains in stable/12 and stable/13.
Support the old, overlapping, call under COMPAT_FREEBSD12.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Nov 15 2021, 9:17 PM
sys/netpfil/pf/pf_ioctl.c
4667

Given you've merged it to stable/13, I think it probably should be COMPAT_FREEBSD13 and use _FREEBSD13 as the suffix. If we don't have a COMPAT_FREEBSD13 option yet, that can be added in a commit before this one (and I can help with that if needed)

(The option in the commit log still says 12, but I realize if you updated it locally, the phab description doesn't auto-update so this might just be stale in phab)

This revision is now accepted and ready to land.Nov 16 2021, 5:49 PM
In D33001#745526, @jhb wrote:

(The option in the commit log still says 12, but I realize if you updated it locally, the phab description doesn't auto-update so this might just be stale in phab)

That's exactly correct, yes. I updated the commit message locally after pushing the update. In part because git-arc uses the commit message to match commits to reviews.

This revision was automatically updated to reflect the committed changes.