Paths

Table of Contentst

Differential D32656

vt: Add devctl message for bells
ClosedPublic
Actions

Authored by imp on Oct 26 2021, 4:31 AM.

Tags

None

Referenced Files

	F134506996: D32656.id97970.diff
	Sun, Nov 2, 5:30 PM

	F134506980: D32656.id97982.diff
	Sun, Nov 2, 5:29 PM

	F134506904: D32656.diff
	Sun, Nov 2, 5:28 PM

	F134506751: D32656.id97452.diff
	Sun, Nov 2, 5:26 PM

	F134506740: D32656.id.diff
	Sun, Nov 2, 5:26 PM

	Unknown Object (File)
	Thu, Oct 30, 2:27 AM

	Unknown Object (File)
	Sat, Oct 25, 6:30 PM

	Unknown Object (File)
	Wed, Oct 22, 12:03 PM

Subscribers

Details

Reviewers

• hselasky
kevans

Group Reviewers

Commits

rGa82d7aeb3f26: vt: Add devctl message for bells
rG4ac3d08a9693: vt: Add devctl message for bells

Summary

Generate VT events when the bell beeps. When coupled with disabling the
bell,this allows custom bells to be rung when we'd otherwise beep.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42362
Build 39250: arc lint + arc unit

Event Timeline

imp created this revision.Oct 26 2021, 4:31 AM

Herald added a reviewer: manpages. · View Herald TranscriptOct 26 2021, 4:31 AM

Herald added a subscriber: asomers. · View Herald Transcript

imp requested review of this revision.Oct 26 2021, 4:31 AM

Harbormaster completed remote builds in B42362: Diff 97452.Oct 26 2021, 4:31 AM

imp added a reviewer: • hselasky.Oct 26 2021, 4:50 AM

kevans added a subscriber: kevans.Oct 26 2021, 5:32 AM

kevans added inline comments.

sbin/devd/devd.conf.5
608
share/man/man4/vt.4
304
sys/dev/vt/vt_core.c
1121	Maybe pedantic, but I think this should capture `(vd->vd_flags & VDF_QUIET_BELL) != 0` as well -- it's not specified in the manpage update whether enabled=false is purely user-driven or if it'll also be set if the console driver's disabled the bell, but I suspect it should cover console-disabled as well. it'd probably be good to juts add a `bell_enabled` bool above that captures the below two cases, so you can just reuse it here and with one return below.

kevans added a reviewer: kevans.Oct 26 2021, 5:33 AM

Looks good! Waiting for a reply on @kevans comments.

emaste added a subscriber: emaste.Oct 26 2021, 1:49 PM

updates in a minute

sys/dev/vt/vt_core.c
1121	I'll go for 'hushed' but I like it.

update per review comments

Harbormaster completed remote builds in B42566: Diff 97970.Nov 3 2021, 9:03 PM

kevans accepted this revision.Nov 3 2021, 9:11 PM

kevans added inline comments.

sys/dev/vt/vt_core.c
1121	perfect, thanks

This revision is now accepted and ready to land.Nov 3 2021, 9:11 PM

Closed by commit rG4ac3d08a9693: vt: Add devctl message for bells (authored by imp). · Explain WhyNov 3 2021, 10:06 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4ac3d08a9693: vt: Add devctl message for bells.

imp added a commit: rGa82d7aeb3f26: vt: Add devctl message for bells.Nov 19 2021, 4:54 AM

Revision Contents
Changeset List

Path

Size

sbin/

devd/

9 lines

share/

man/

man4/

14 lines

sys/

dev/

vt/

36 lines

Diff 97452

sbin/devd/devd.conf.5

Loading...

share/man/man4/vt.4

Loading...

sys/dev/vt/vt_core.c

Loading...