Page MenuHomeFreeBSD

vt: Add devctl message for bells
ClosedPublic

Authored by imp on Oct 26 2021, 4:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 9 2024, 7:38 AM
Unknown Object (File)
Mar 9 2024, 7:38 AM
Unknown Object (File)
Mar 9 2024, 7:38 AM
Unknown Object (File)
Mar 9 2024, 7:38 AM
Unknown Object (File)
Mar 9 2024, 7:27 AM
Unknown Object (File)
Mar 7 2024, 5:16 PM
Unknown Object (File)
Jan 12 2024, 8:50 AM
Unknown Object (File)
Jan 11 2024, 2:04 AM

Details

Summary

Generate VT events when the bell beeps. When coupled with disabling the
bell,this allows custom bells to be rung when we'd otherwise beep.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 26 2021, 4:31 AM
kevans added inline comments.
sbin/devd/devd.conf.5
608
share/man/man4/vt.4
304
sys/dev/vt/vt_core.c
1121

Maybe pedantic, but I think this should capture (vd->vd_flags & VDF_QUIET_BELL) != 0 as well -- it's not specified in the manpage update whether enabled=false is purely user-driven or if it'll also be set if the console driver's disabled the bell, but I suspect it should cover console-disabled as well.

it'd probably be good to juts add a bell_enabled bool above that captures the below two cases, so you can just reuse it here and with one return below.

Looks good! Waiting for a reply on @kevans comments.

imp marked 2 inline comments as done.Nov 3 2021, 8:55 PM

updates in a minute

sys/dev/vt/vt_core.c
1121

I'll go for 'hushed' but I like it.

update per review comments

kevans added inline comments.
sys/dev/vt/vt_core.c
1121

perfect, thanks

This revision is now accepted and ready to land.Nov 3 2021, 9:11 PM
This revision was automatically updated to reflect the committed changes.