Page MenuHomeFreeBSD
Differential D32071

cmp: accept SI suffixes for skip1 and skip2
ClosedPublic
Actions

Authored by kevans on Sep 23 2021, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 2:29 PM
Unknown Object (File)
Tue, Jun 25, 11:55 AM
Unknown Object (File)
Tue, Jun 25, 10:25 AM
Unknown Object (File)
Sat, Jun 22, 2:24 PM
Unknown Object (File)
Tue, Jun 18, 11:55 AM
Unknown Object (File)
Mon, Jun 17, 4:58 AM
Unknown Object (File)
Sun, Jun 16, 6:14 PM
Unknown Object (File)
Sun, Jun 16, 6:54 AM
View All 39 Files
Subscribers
imp

Details

Reviewers
emaste
bapt
markj
allanjude
imp
Group Reviewers
manpages
Commits
rGf6787614fd4d: cmp: accept SI suffixes for skip1 and skip2
Summary

This is compatible with GNU cmp.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Sep 23 2021, 5:55 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2021, 5:55 AM
Herald added a subscriber: imp. · View Herald Transcript
kevans requested review of this revision.Sep 23 2021, 5:55 AM
Harbormaster completed remote builds in B41658: Diff 95543.Sep 23 2021, 5:55 AM
kevans added a child revision: D32072: cmp: add -n, --bytes to limit number of bytes to compare.Sep 23 2021, 5:56 AM
bapt accepted this revision.Sep 23 2021, 10:09 AM
This revision is now accepted and ready to land.Sep 23 2021, 10:09 AM
imp added inline comments.Sep 23 2021, 12:17 PM
usr.bin/cmp/cmp.1
93

Power of 2 or power of 10?

imp added inline comments.Sep 23 2021, 12:19 PM
usr.bin/cmp/tests/cmp_test2.sh
91

This test suggests not SI bot power of 2

imp requested changes to this revision.Sep 23 2021, 12:53 PM

These suffixes are the power-of-two suffixes, not the SI suffixes which are strictly power of 10.

While I don't mind if we accept them as power-of-two, we shouldn't use 'SI' to refer to them.
Of course, we do refer to them incorrectly in that way in expand_number(3).
We use the SI names for the IEE/IEC values.

This revision now requires changes to proceed.Sep 23 2021, 12:53 PM
imp added a comment.Sep 23 2021, 2:26 PM

Maybe just an entry in the bugs section that SI suffixes use the traditional power of 2 values as described in .Xr expand_number 3.

usr.bin/cmp/cmp.1
93

"may also be specified with power of 2 size suffixes."

w

kevans updated this revision to Diff 95573.Sep 23 2021, 6:00 PM

Address imp's feedback

Harbormaster completed remote builds in B41675: Diff 95573.Sep 23 2021, 6:00 PM
imp added a comment.Sep 23 2021, 8:03 PM

One last minor nit. Thanks for listening.

usr.bin/cmp/cmp.1
182

maybe s/verbiage/phrase/ here makes sense?

kevans updated this revision to Diff 95583.Sep 23 2021, 8:04 PM

s/verbiage/phrase/

Harbormaster completed remote builds in B41680: Diff 95583.Sep 23 2021, 8:04 PM
imp accepted this revision.Sep 23 2021, 8:10 PM
This revision is now accepted and ready to land.Sep 23 2021, 8:10 PM
markj accepted this revision.Sep 24 2021, 1:09 PM
Closed by commit rGf6787614fd4d: cmp: accept SI suffixes for skip1 and skip2 (authored by kevans). · Explain WhySep 29 2021, 6:05 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGf6787614fd4d: cmp: accept SI suffixes for skip1 and skip2.

Revision Contents
Changeset List

PathSize
usr.bin/
cmp/
2 lines
16 lines
14 lines
tests/
17 lines

Diff 95960

View Options

usr.bin/cmp/Makefile

Loading...
View Options

usr.bin/cmp/cmp.1

Loading...
View Options

usr.bin/cmp/cmp.c

Loading...
View Options

usr.bin/cmp/tests/cmp_test2.sh

Loading...