Page MenuHomeFreeBSD
Differential D32073

cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args
ClosedPublic
Actions

Authored by kevans on Sep 23 2021, 5:56 AM.
Tags
None
Referenced Files
F171423875: D32073.diff
Fri, Sep 11, 1:43 AM
Unknown Object (File)
Wed, Sep 9, 7:21 PM
Unknown Object (File)
Sat, Sep 5, 6:38 PM
Unknown Object (File)
Sat, Sep 5, 4:45 AM
Unknown Object (File)
Fri, Sep 4, 10:06 PM
Unknown Object (File)
Fri, Sep 4, 8:20 PM
Unknown Object (File)
Fri, Sep 4, 8:07 PM
Unknown Object (File)
Fri, Sep 4, 12:03 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
bapt
markj
allanjude
Group Reviewers
manpages
Commits
rG8d546b6832ee: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Sep 23 2021, 5:56 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2021, 5:56 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B41660: Diff 95545.Sep 23 2021, 5:56 AM
kevans requested review of this revision.Sep 23 2021, 5:56 AM
kevans added a parent revision: D32072: cmp: add -n, --bytes to limit number of bytes to compare.
kevans added a child revision: D32074: cmp: add -b, --print-bytes.
markj accepted this revision.Sep 23 2021, 6:39 PM
markj added inline comments.
usr.bin/cmp/cmp.c
85

I think this check is not needed, expand_number() will handle it.

This revision is now accepted and ready to land.Sep 23 2021, 6:39 PM
kevans marked an inline comment as done.Sep 23 2021, 6:52 PM
Closed by commit rG8d546b6832ee: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args (authored by kevans). · Explain WhySep 29 2021, 6:05 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG8d546b6832ee: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args.

Revision Contents
Changeset List

PathSize
usr.bin/
cmp/
19 lines
30 lines
tests/
5 lines

Diff 95962

View Options

usr.bin/cmp/cmp.1

Loading...
View Options

usr.bin/cmp/cmp.c

Loading...
View Options

usr.bin/cmp/tests/cmp_test2.sh

Loading...