Differential D32034

vm_page: Drop handling of VM_ALLOC_NOOBJ in vm_page_alloc_contig_domain()
ClosedPublic
Actions

Authored by markj on Sep 21 2021, 2:44 AM.

Tags

None

Referenced Files

	F108500417: D32034.diff
	Sat, Jan 25, 3:59 PM

	F108497259: D32034.id97018.diff
	Sat, Jan 25, 2:52 PM

	Unknown Object (File)
	Fri, Jan 24, 12:53 AM

	Unknown Object (File)
	Sun, Jan 19, 2:00 AM

	Unknown Object (File)
	Sat, Jan 18, 5:49 PM

	Unknown Object (File)
	Sat, Jan 18, 5:19 PM

	Unknown Object (File)
	Sat, Jan 18, 5:17 PM

	Unknown Object (File)
	Sat, Jan 18, 5:06 PM

Subscribers

Details

Reviewers

alc
kib

Commits

rG02fb0585e7b3: vm_page: Drop handling of VM_ALLOC_NOOBJ in vm_page_alloc_contig_domain()

Summary

As in vm_page_alloc_domain_after(), unconditionally preserve PG_ZERO.

Implement vm_page_alloc_noobj_contig_domain().

MFC after: never

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41623
Build 38512: arc lint + arc unit

Event Timeline

markj created this revision.Sep 21 2021, 2:44 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2021, 2:44 AM

markj requested review of this revision.Sep 21 2021, 2:44 AM

Harbormaster completed remote builds in B41612: Diff 95415.Sep 21 2021, 2:44 AM

Call vm_page_alloc_check() and vm_page_alloc_dequeue() in the right order.

Harbormaster completed remote builds in B41616: Diff 95419.Sep 21 2021, 3:47 AM

kib accepted this revision.Sep 21 2021, 12:42 PM

This revision is now accepted and ready to land.Sep 21 2021, 12:42 PM

Add assertions to exclude all unexpected flags.

This revision now requires review to proceed.Sep 21 2021, 3:14 PM

Harbormaster completed remote builds in B41623: Diff 95453.Sep 21 2021, 3:14 PM

kib accepted this revision.Sep 22 2021, 3:25 PM

This revision is now accepted and ready to land.Sep 22 2021, 3:25 PM

markj added inline comments.Sep 22 2021, 3:33 PM

sys/vm/vm_page.c
2575	Missing a conditional pmap_page_set_memattr() call here.

markj mentioned this in D32036: vm_fault: Stop specifying VM_ALLOC_ZERO.Sep 24 2021, 4:50 PM

markj added a parent revision: D32033: vm_page: Stop handling VM_ALLOC_NOOBJ in vm_page_alloc_domain_after().Oct 1 2021, 9:56 PM

markj added a child revision: D32035: Rewrite the vm_page_alloc manual page.

I'm unclear on whether the conditional pmap_page_set_memattr() call was added.

Update mappings of the returned pages if memattr != VM_MEMATTR_DEFAULT.

This revision now requires review to proceed.Oct 17 2021, 8:50 PM

Harbormaster completed remote builds in B42202: Diff 97018.Oct 17 2021, 8:50 PM

alc added inline comments.Oct 18 2021, 12:38 AM

sys/vm/vm_page.c
2576–2577	Since this function only applies to ordinary (DRAM) memory, I would do the zeroing before changing the memattr. Until we return from this function, the pages are not yet being shared with whatever device might have led us to, for example, make the pages uncacheable.

Zero newly allocated pages before updating the direct map.

Harbormaster completed remote builds in B42211: Diff 97027.Oct 18 2021, 1:13 AM

markj added inline comments.Oct 18 2021, 1:20 AM

sys/vm/vm_page.c
2576–2577	I'd forgotten that pmap_page_set_memattr() flushes caches, otherwise it would seem incorrect in general to zero the page first. Maybe this deserves a comment.

alc added inline comments.Oct 18 2021, 8:23 AM

sys/vm/vm_page.c
2576–2577	Yes, this deserves a comment.

Explain why we zero the page before setting a memory attribute.

Harbormaster completed remote builds in B42228: Diff 97054.Oct 18 2021, 1:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 20 2021, 1:23 AM

Closed by commit rG02fb0585e7b3: vm_page: Drop handling of VM_ALLOC_NOOBJ in vm_page_alloc_contig_domain() (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG02fb0585e7b3: vm_page: Drop handling of VM_ALLOC_NOOBJ in vm_page_alloc_contig_domain().

Revision Contents
Changeset List

Path

Size

sys/

vm/

170 lines

Diff 95453

sys/vm/vm_page.c

Loading...