Differential D31374

udp: Fix soroverflow SOCKBUF unlocking
ClosedPublic
Actions

Authored by kbowling on Aug 1 2021, 2:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 12, 1:23 AM

	Unknown Object (File)
	Sat, May 4, 1:17 PM

	Unknown Object (File)
	Wed, May 1, 10:58 PM

	Unknown Object (File)
	Thu, Apr 25, 11:03 AM

	Unknown Object (File)
	Apr 6 2024, 4:16 PM

	Unknown Object (File)
	Apr 6 2024, 9:34 AM

	Unknown Object (File)
	Jan 11 2024, 4:47 PM

	Unknown Object (File)
	Dec 20 2023, 6:42 AM

View All 21 Files

Subscribers

Details

Reviewers

philip
ae
scottl

Group Reviewers

Commits

rGae51594c9794: udp: Fix soroverflow SOCKBUF unlocking
rG2141aab35b70: udp: Fix soroverflow SOCKBUF unlocking
rGa61c24ddb7d6: udp: Fix soroverflow SOCKBUF unlocking

Summary

Author: Konstantin Kukushkin <darkdestructor@rambler.ru>

We hold the SOCKBUF_LOCK so use soroverflow_locked here.
This bug may manifest as a non-killable process stuck in [*so_rcv].

Reviewed by:    Roy Marples <roy@marples.name>
Fixes:  7045b1603bdf
MFC after:  10 days

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Aug 1 2021, 2:54 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 1 2021, 2:54 PM

Herald added a subscriber: melifaro. · View Herald Transcript

kbowling requested review of this revision.Aug 1 2021, 2:54 PM

scottl accepted this revision.Aug 1 2021, 3:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2021, 3:09 PM

Closed by commit rGa61c24ddb7d6: udp: Fix soroverflow SOCKBUF unlocking (authored by Konstantin Kukushkin <darkdestructor@rambler.ru>, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGa61c24ddb7d6: udp: Fix soroverflow SOCKBUF unlocking.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG2141aab35b70: udp: Fix soroverflow SOCKBUF unlocking.Aug 11 2021, 1:58 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGae51594c9794: udp: Fix soroverflow SOCKBUF unlocking.Aug 11 2021, 2:34 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

2 lines

Diff 93079

sys/netinet/udp_usrreq.c

Loading...