Page MenuHomeFreeBSD
Differential D31333

Add macros for arm64 special reg op and CR values
ClosedPublic
Actions

Authored by andrew on Jul 28 2021, 2:22 PM.
Tags
None
Referenced Files
F157030820: D31333.id92859.diff
Mon, May 18, 1:14 AM
F157030805: D31333.id92864.diff
Mon, May 18, 1:14 AM
F157030764: D31333.id92859.diff
Mon, May 18, 1:13 AM
F157027907: D31333.diff
Mon, May 18, 12:52 AM
Unknown Object (File)
Thu, May 14, 5:22 PM
Unknown Object (File)
Sat, May 9, 4:28 AM
Unknown Object (File)
Fri, May 8, 9:19 PM
Unknown Object (File)
Wed, May 6, 2:42 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
kib
markj
manu
imp
Group Reviewers
arm64
Commits
rGc7937cf1d347: Add macros for arm64 special reg op and CR values
rG10f6680faae0: Add macros for arm64 special reg op and CR values
Summary

Use these to simplify the definition of the user_regs array.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Jul 28 2021, 2:22 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 28 2021, 2:22 PM
Herald added a subscriber: imp. · View Herald Transcript
andrew requested review of this revision.Jul 28 2021, 2:22 PM
Harbormaster completed remote builds in B40717: Diff 92859.Jul 28 2021, 2:22 PM
imp accepted this revision.Jul 28 2021, 2:42 PM

The macro magic looks good to me, but I didn't check that all the macro args were transcribed to FOO_xxx correctly. The few I did check were right.

This revision is now accepted and ready to land.Jul 28 2021, 2:42 PM
markj accepted this revision.Jul 28 2021, 2:44 PM
andrew added a comment.Jul 28 2021, 2:48 PM
In D31333#705812, @imp wrote:

The macro magic looks good to me, but I didn't check that all the macro args were transcribed to FOO_xxx correctly. The few I did check were right.

I've scripted it to extract values from Arm provided XML.

Closed by commit rG10f6680faae0: Add macros for arm64 special reg op and CR values (authored by andrew). · Explain WhyJul 28 2021, 3:21 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG10f6680faae0: Add macros for arm64 special reg op and CR values.
andrew added a commit: rGc7937cf1d347: Add macros for arm64 special reg op and CR values.Aug 30 2021, 12:44 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
82 lines
include/
83 lines

Diff 92864

View Options

sys/arm64/arm64/identcpu.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...