Page MenuHomeFreeBSD
Differential D30811

Correct loopback route for aliases IP addresses
AbandonedPublic
Actions

Authored by zlei on Jun 18 2021, 7:50 AM.
Tags
Referenced Files
F115535201: D30811.diff
Fri, Apr 25, 12:04 AM
Unknown Object (File)
Wed, Apr 23, 7:41 AM
Unknown Object (File)
Wed, Apr 23, 4:36 AM
Unknown Object (File)
Wed, Apr 23, 3:02 AM
Unknown Object (File)
Wed, Apr 23, 2:26 AM
Unknown Object (File)
Sat, Apr 19, 12:29 AM
Unknown Object (File)
Mar 17 2025, 3:08 AM
Unknown Object (File)
Jan 23 2025, 3:11 PM
View All 49 Files
Subscribers
donner
imp
kp

Details

Reviewers
melifaro
Group Reviewers
network
Summary

A loopback route is required only when the logical interface is not a loopback.

PR: 256681

Test Plan

Create loopback, tun and tap clones, with IP address and IP aliases, verify the route table is expected.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Jun 18 2021, 7:50 AM
zlei created this revision.
zlei added inline comments.Jun 18 2021, 7:54 AM
sys/netinet/in.c
780

TODO: Need revision to reflect the change.

zlei edited the test plan for this revision. (Show Details)Jun 18 2021, 7:55 AM
zlei edited the summary of this revision. (Show Details)Jun 18 2021, 8:02 AM
zlei added inline comments.Jun 18 2021, 8:07 AM
sys/netinet/in.c
938

Not sure if it is useful to routing daemons.

donner added a subscriber: donner.Jun 18 2021, 10:34 AM

I'm surprised. There was a discussion about not redirecting /32 on interfaces to loopback. So we see the consequence.

kp added a subscriber: kp.Jun 18 2021, 12:37 PM

I believe this bug is also related: #255685

zlei added a comment.Jun 19 2021, 12:58 PM
In D30811#692900, @donner wrote:

I'm surprised. There was a discussion about not redirecting /32 on interfaces to loopback. So we see the consequence.

Can you please share the discussion? Thanks!

zlei added a comment.Jun 21 2021, 9:24 AM

I think I hit the issue that the useloopback was trying to resolve.

[1]: https://cgit.freebsd.org/src/commit/sys/?h=stable/8&id=df813b7ea23bd5d41359f0c7bf8b69ee89b7e1c6
[2]: https://cgit.freebsd.org/src/commit/sys?h=stable/11&id=b1b9dcae46803ae79255a9994584cb03d2a77048

donner added a comment.Jun 21 2021, 11:02 AM
In D30811#693218, @zlei.huang_gmail.com wrote:

Can you please share the discussion? Thanks!

Unfortunately not. The mailing list archive is not accessible to me.

zlei abandoned this revision.Oct 6 2021, 7:46 AM

Abandoned since it works as intended.

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2021, 7:46 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
13 lines

Diff 91043

View Options

sys/netinet/in.c

This file was completely deleted. Show File Contents