Page MenuHomeFreeBSD
Differential D30151

Fix mbuf leaks in various pru_send implementations
ClosedPublic
Actions

Authored by markj on May 6 2021, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 11:26 AM
Unknown Object (File)
Fri, Mar 27, 10:59 AM
Unknown Object (File)
Sat, Mar 21, 5:36 AM
Unknown Object (File)
Thu, Mar 19, 12:51 PM
Unknown Object (File)
Thu, Mar 19, 8:04 AM
Unknown Object (File)
Sun, Mar 15, 4:24 AM
Unknown Object (File)
Sat, Mar 7, 8:49 PM
Unknown Object (File)
Fri, Mar 6, 11:51 PM
View All Files
Subscribers
ae
bz
imp
melifaro

Details

Reviewers
melifaro
tuexen
jtl
Group Reviewers
transport
network
Commits
rGd8acd2681bcf: Fix mbuf leaks in various pru_send implementations
Summary

The various protocol implementations are not very consistent about
freeing mbufs in error paths. In general, all protocols must free both
"m" and "control" upon an error, except if PRUS_NOTREADY is specified
(this is only implemented by TCP and unix(4) and requires further work
not handled in this diff), in which case "control" still must be freed.

This diff plugs various leaks in the pru_send implementations.

N.B. in general we seem to avoid calling m_freem(NULL), though this
works fine in practice and would be consistent with other kernel memory
allocators. Is there some reason to keep this pattern?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines
netinet/
2 lines
19 lines
77 lines
1 line
netinet6/
40 lines
25 lines
3 lines

Diff 89083

View Options

sys/kern/uipc_socket.c

Loading...
View Options

sys/netinet/ip_divert.c

Loading...
View Options

sys/netinet/raw_ip.c

Loading...
View Options

sys/netinet/tcp_usrreq.c

Loading...
View Options

sys/netinet/udp_usrreq.c

Loading...
View Options

sys/netinet6/raw_ip6.c

Loading...
View Options

sys/netinet6/sctp6_usrreq.c

Loading...
View Options

sys/netinet6/send.c

Loading...