linuxkpi: Implement atomic_dec_and_lock_irqsave()
ClosedPublic
Actions

Authored by nc on Apr 26 2021, 1:17 AM.

Details

Reviewers

manu
hselasky

Commits

rGda6a8ccfa293: linuxkpi: Implement atomic_dec_and_lock_irqsave()
rGce65353ac1a1: linuxkpi: Implement atomic_dec_and_lock_irqsave()

Summary

This is needed by the drm-kmod 5.5 update.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nc created this revision.Apr 26 2021, 1:17 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptApr 26 2021, 1:17 AM

nc requested review of this revision.Apr 26 2021, 1:17 AM

Harbormaster completed remote builds in B38859: Diff 88145.Apr 26 2021, 1:18 AM

hselasky accepted this revision.Apr 26 2021, 7:37 AM

hselasky added a subscriber: hselasky.

hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/spinlock.h
168	Don't need brackets around this return.

This revision is now accepted and ready to land.Apr 26 2021, 7:37 AM

Same comment as Hans :)
And please bump FreeBSD_version so we can check this in the drm-devel-kmod in the near futur.

Closed by commit rGce65353ac1a1: linuxkpi: Implement atomic_dec_and_lock_irqsave() (authored by nc). · Explain WhyApr 26 2021, 3:16 PM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rGce65353ac1a1: linuxkpi: Implement atomic_dec_and_lock_irqsave().

hselasky added inline comments.Apr 26 2021, 3:40 PM

sys/compat/linuxkpi/common/include/linux/spinlock.h
173	Parenthesis around return result is fine.

nc added a commit: rGda6a8ccfa293: linuxkpi: Implement atomic_dec_and_lock_irqsave().Apr 26 2021, 3:46 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

spinlock.h

13 lines

sys/

param.h

2 lines

Diff 88178

View Options

sys/compat/linuxkpi/common/include/linux/spinlock.h