Page MenuHomeFreeBSD

tcp: Shouldn't drain empty sbuf
ClosedPublic

Authored by rscheff on Mar 31 2021, 11:01 PM.
Tags
None
Referenced Files
F132058342: D29524.diff
Mon, Oct 13, 7:16 AM
Unknown Object (File)
Sun, Oct 5, 5:02 AM
Unknown Object (File)
Sat, Oct 4, 4:13 PM
Unknown Object (File)
Wed, Oct 1, 1:25 AM
Unknown Object (File)
Sun, Sep 28, 3:46 PM
Unknown Object (File)
Mon, Sep 15, 8:51 AM
Unknown Object (File)
Sep 13 2025, 10:10 AM
Unknown Object (File)
Sep 9 2025, 3:37 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • fix typo in assert string
sys/netinet/tcp_hostcache.c
709

Maybe add a comment why you are doing this dance. It wasn't obvious for us...

  • add comment to explain why do_drain is needed
sys/netinet/tcp_hostcache.c
711

Not sure coordination is involved. Isn't it more that one should not call sbuf_drain() with an empty buffer. Please state that and finish the sentence with a full stop (.).

This revision is now accepted and ready to land.Apr 1 2021, 2:40 PM
This revision was automatically updated to reflect the committed changes.

I would probably instead have changed sbuf_drain() to just return instead of asserting. Asserting made sense when it was a private implementation function, as a public API I think just returning instead of asserting is better behavior.