Page MenuHomeFreeBSD

tcp: Shouldn't drain empty sbuf
ClosedPublic

Authored by rscheff on Mar 31 2021, 11:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 25 2024, 9:50 AM
Unknown Object (File)
Dec 14 2023, 5:24 PM
Unknown Object (File)
Dec 12 2023, 1:04 AM
Unknown Object (File)
Dec 1 2023, 3:18 PM
Unknown Object (File)
Dec 1 2023, 3:13 PM
Unknown Object (File)
Dec 1 2023, 3:13 PM
Unknown Object (File)
Sep 20 2023, 9:38 PM
Unknown Object (File)
Sep 5 2023, 1:43 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38230
Build 35119: arc lint + arc unit

Event Timeline

  • fix typo in assert string
sys/netinet/tcp_hostcache.c
696

Maybe add a comment why you are doing this dance. It wasn't obvious for us...

  • add comment to explain why do_drain is needed
sys/netinet/tcp_hostcache.c
698

Not sure coordination is involved. Isn't it more that one should not call sbuf_drain() with an empty buffer. Please state that and finish the sentence with a full stop (.).

This revision is now accepted and ready to land.Apr 1 2021, 2:40 PM
This revision was automatically updated to reflect the committed changes.

I would probably instead have changed sbuf_drain() to just return instead of asserting. Asserting made sense when it was a private implementation function, as a public API I think just returning instead of asserting is better behavior.