Paths

Table of Contentst

Differential D29495

sys/linker_set.h: Add SET_DECLARE_WEAK()
AbandonedPublic
Actions

Authored by arichardson on Mar 30 2021, 1:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 13, 9:33 PM

	Unknown Object (File)
	Sat, Apr 13, 9:17 PM

	Unknown Object (File)
	Sat, Apr 13, 9:05 PM

	Unknown Object (File)
	Sat, Apr 13, 8:05 PM

	Unknown Object (File)
	Thu, Apr 11, 11:17 PM

	Unknown Object (File)
	Thu, Apr 11, 10:33 PM

	Unknown Object (File)
	Feb 18 2024, 6:28 AM

	Unknown Object (File)
	Feb 9 2024, 4:29 PM

View All 44 Files

Subscribers

Details

Reviewers

dim
brooks
jrtc27
jhb
val_packett.cool
kib

Summary

Clang 12 does not allow re-defining weak symbols as non-weak. Therefore, if
we have both SET_DECLARE and DATA_SET/etc. in the same file this triggers
compiler errors. This commit changes the default behaviour of SET_DECLARE()
to declare a non-weak symbol (i.e. we will get linker errors if the set is
empty) and adds a new SET_DECLARE_WEAK() that can be used for optional
linker sets.

This also drops the __GLOBL() that was added back in commit
566af50bd26d7739d1e62d23438b32aef21383eb (r215137)
since both ld.bfd and ld.lld automatically add the __start/__stop
symbols for all orphan sections with the name being a valid C identifier.

Test Plan

fixes compilation errors

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38179
Build 35068: arc lint + arc unit

Event Timeline

arichardson created this revision.Mar 30 2021, 1:57 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2021, 1:57 PM

Harbormaster completed remote builds in B38178: Diff 86547.Mar 30 2021, 1:57 PM

arichardson requested review of this revision.Mar 30 2021, 1:57 PM

jrtc27 added inline comments.Mar 30 2021, 1:59 PM

sys/sys/linker_set.h
96	Maybe makes more sense to flip these around so SET_DECLARE comes first and is the primary one?

arichardson added inline comments.Mar 30 2021, 2:02 PM

sys/sys/linker_set.h
96	Yes sounds good, will switch them.

jrtc27 added inline comments.Mar 30 2021, 2:03 PM

sys/sys/linker_set.h
96	The alternative is to abuse ptype and just make the callers who want a weak symbol use SET_DECLARE(foo, struct bar __weak_symbol)... :)

switch order

Harbormaster completed remote builds in B38179: Diff 86549.Mar 30 2021, 2:24 PM

add missed case

Harbormaster completed remote builds in B38182: Diff 86557.Mar 30 2021, 3:50 PM

arichardson mentioned this in D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.Mar 31 2021, 7:15 PM

arichardson added a reviewer: val_packett.cool.Mar 31 2021, 7:39 PM

Builds fine for me

This revision is now accepted and ready to land.Apr 1 2021, 1:33 PM

drop __GLOBL()

This revision now requires review to proceed.Apr 7 2021, 1:19 PM

Harbormaster completed remote builds in B38382: Diff 86959.Apr 7 2021, 1:19 PM

arichardson edited the summary of this revision. (Show Details)Apr 7 2021, 1:19 PM

tinderbox fixes

Herald added a subscriber: andrew. · View Herald TranscriptApr 8 2021, 10:37 AM

Harbormaster completed remote builds in B38401: Diff 87013.Apr 8 2021, 10:37 AM

arichardson edited the summary of this revision. (Show Details)Apr 8 2021, 10:39 AM

arichardson changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

arichardson edited the summary of this revision. (Show Details)Apr 8 2021, 10:42 AM

arichardson added a reviewer: kib.

Have to handle the kernel module case, so we do actually need the __GLOBL().

Abandoning in favour of D29159

Revision Contents
Changeset List

Path

Size

lib/

libkvm/

2 lines

sys/

dev/

uart/

2 lines

sys/

7 lines

Diff 86549

lib/libkvm/kvm.c

Loading...

sys/dev/uart/uart_cpu_fdt.h

Loading...

sys/sys/linker_set.h

Loading...