Fix several dev_clone callbacks to avoid out-of-bounds reads
ClosedPublic
Actions

Authored by markj on Mar 28 2021, 12:00 AM.

Details

Reviewers

kib
emaste

Commits

rGf9fcb518e728: Fix several dev_clone callbacks to avoid out-of-bounds reads
rG381ba4357c74: Fix several dev_clone callbacks to avoid out-of-bounds reads
rG3428b6c050d1: Fix several dev_clone callbacks to avoid out-of-bounds reads

Summary

Use strncmp() instead of bcmp(), so that we don't have to find the
minimum of the string lengths before comparing.

Reported by: KASAN

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 28 2021, 12:00 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2021, 12:00 AM

markj requested review of this revision.Mar 28 2021, 12:00 AM

Harbormaster completed remote builds in B38134: Diff 86420.Mar 28 2021, 12:00 AM

markj added reviewers: kib, emaste.Mar 28 2021, 1:22 AM

kib accepted this revision.Mar 28 2021, 2:08 AM

This revision is now accepted and ready to land.Mar 28 2021, 2:08 AM

Closed by commit rG3428b6c050d1: Fix several dev_clone callbacks to avoid out-of-bounds reads (authored by markj). · Explain WhyMar 28 2021, 3:09 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3428b6c050d1: Fix several dev_clone callbacks to avoid out-of-bounds reads.

markj added a commit: rG381ba4357c74: Fix several dev_clone callbacks to avoid out-of-bounds reads.Mar 31 2021, 1:16 PM

markj added a commit: rGf9fcb518e728: Fix several dev_clone callbacks to avoid out-of-bounds reads.Mar 31 2021, 1:23 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

dsp.c

3 lines

kern/

kern_conf.c

2 lines

Diff 86437

View Options

sys/dev/sound/pcm/dsp.c