Page MenuHomeFreeBSD
Differential D49804

sound: Access softc through si_drv1 in dsp cdev methods
ClosedPublic
Actions

Authored by christos on Apr 12 2025, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 5:18 AM
Unknown Object (File)
Wed, Sep 2, 3:07 PM
Unknown Object (File)
Wed, Sep 2, 2:54 PM
Unknown Object (File)
Wed, Sep 2, 9:26 AM
Unknown Object (File)
Mon, Aug 31, 11:28 AM
Unknown Object (File)
Sun, Aug 30, 3:04 PM
Unknown Object (File)
Tue, Aug 18, 10:35 AM
Unknown Object (File)
Sat, Aug 15, 2:02 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
kib
dev_submerge.ch
Commits
rGfacccfc8c7e1: sound: Access softc through si_drv1 in dsp cdev methods
Summary

No functional change, but is needed by a follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Apr 12 2025, 8:13 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2025, 8:13 PM
christos requested review of this revision.Apr 12 2025, 8:13 PM
Harbormaster completed remote builds in B63480: Diff 153587.Apr 12 2025, 8:13 PM
christos added a child revision: D49805: sound: Create a dsp_close() helper function.Apr 12 2025, 8:13 PM
christos added a child revision: D49216: sound: Implement /dev/dsp as a router device.Apr 12 2025, 8:14 PM
christos removed a child revision: D49216: sound: Implement /dev/dsp as a router device.
markj added a comment.Apr 13 2025, 4:05 PM

So should the priv->sc field be removed entirely?

christos added a comment.Apr 14 2025, 2:15 PM
In D49804#1135648, @markj wrote:

So should the priv->sc field be removed entirely?

So, as I mention in the commit message, this is just part of a series of patches, and the last patch (at its current form) which is not yet submitted here, _does_ get rid of priv->sc eventually, however D49216 still needs it.

kib accepted this revision.Apr 14 2025, 3:52 PM
This revision is now accepted and ready to land.Apr 14 2025, 3:52 PM
markj accepted this revision.Apr 14 2025, 7:11 PM
christos added a parent revision: D49978: sound: Retire SD_F_PRIO_*.Apr 23 2025, 12:12 PM
Closed by commit rGfacccfc8c7e1: sound: Access softc through si_drv1 in dsp cdev methods (authored by christos). · Explain WhyApr 25 2025, 4:57 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGfacccfc8c7e1: sound: Access softc through si_drv1 in dsp cdev methods.
christos added a reverting change: rGb095a41a3a2a: Revert "sound: Access softc through si_drv1 in dsp cdev methods".Apr 25 2025, 10:04 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
24 lines

Diff 154287

View Options

sys/dev/sound/pcm/dsp.c

Loading...