Page MenuHomeFreeBSD

sound: Create a dsp_close() helper function
ClosedPublic

Authored by christos on Apr 12 2025, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 6:53 AM
Unknown Object (File)
Tue, Oct 7, 8:49 AM
Unknown Object (File)
Mon, Sep 29, 6:21 PM
Unknown Object (File)
Sep 17 2025, 3:14 AM
Unknown Object (File)
Sep 15 2025, 10:30 PM
Unknown Object (File)
Sep 3 2025, 7:27 PM
Unknown Object (File)
Aug 15 2025, 12:01 AM
Unknown Object (File)
Aug 13 2025, 2:17 AM
Subscribers

Details

Summary

Needed by follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 13 2025, 4:02 PM
sys/dev/sound/pcm/dsp.c
268

So where are these non-NULL checks in the new code?

sys/dev/sound/pcm/dsp.c
268

At the very beginning of dsp_close_chan().

sys/dev/sound/pcm/dsp.c
268

Are the values of priv->{rd,wr}ch stable? You are now checking for their non-NULL after priv->sc acquire.

sys/dev/sound/pcm/dsp.c
268

Primary (i.e., non-vchan) channels are destroyed during detach (see pcm_killchans()), and vchans in dsp_close() (see vchan_destroy()). So I think it's safe to leave the check as is. If we're detaching, we'll catch that a few lines below and bail-out anyway, and for vchans, well, we destroy them here only.

This revision was automatically updated to reflect the committed changes.