Page MenuHomeFreeBSD
Differential D49805

sound: Create a dsp_close() helper function
ClosedPublic
Actions

Authored by christos on Apr 12 2025, 8:13 PM.
Tags
None
Referenced Files
F153185612: D49805.id153588.diff
Sun, Apr 19, 4:30 PM
F153185535: D49805.id153588.diff
Sun, Apr 19, 4:29 PM
Unknown Object (File)
Sat, Apr 18, 11:55 AM
Unknown Object (File)
Sat, Apr 18, 7:30 AM
Unknown Object (File)
Sat, Apr 18, 2:07 AM
Unknown Object (File)
Thu, Apr 16, 2:08 PM
Unknown Object (File)
Sun, Apr 12, 11:31 PM
Unknown Object (File)
Tue, Apr 7, 9:14 PM
View All 87 Files
Subscribers
imp

Details

Reviewers
markj
emaste
kib
dev_submerge.ch
Commits
rG532b45fe103c: sound: Create a dsp_close() helper function
Summary

Needed by follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Apr 12 2025, 8:13 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2025, 8:13 PM
christos requested review of this revision.Apr 12 2025, 8:13 PM
Harbormaster completed remote builds in B63481: Diff 153588.Apr 12 2025, 8:13 PM
christos added a parent revision: D49804: sound: Access softc through si_drv1 in dsp cdev methods.Apr 12 2025, 8:13 PM
christos added a child revision: D49216: sound: Implement /dev/dsp as a router device.Apr 12 2025, 8:14 PM
markj accepted this revision.Apr 13 2025, 4:02 PM
This revision is now accepted and ready to land.Apr 13 2025, 4:02 PM
kib added inline comments.Apr 14 2025, 3:54 PM
sys/dev/sound/pcm/dsp.c
268

So where are these non-NULL checks in the new code?

christos added inline comments.Apr 14 2025, 3:56 PM
sys/dev/sound/pcm/dsp.c
268

At the very beginning of dsp_close_chan().

kib added inline comments.Apr 14 2025, 4:01 PM
sys/dev/sound/pcm/dsp.c
268

Are the values of priv->{rd,wr}ch stable? You are now checking for their non-NULL after priv->sc acquire.

christos added inline comments.Apr 15 2025, 5:36 PM
sys/dev/sound/pcm/dsp.c
268

Primary (i.e., non-vchan) channels are destroyed during detach (see pcm_killchans()), and vchans in dsp_close() (see vchan_destroy()). So I think it's safe to leave the check as is. If we're detaching, we'll catch that a few lines below and bail-out anyway, and for vchans, well, we destroy them here only.

kib accepted this revision.Apr 15 2025, 6:04 PM
christos marked 2 inline comments as done.Apr 15 2025, 6:06 PM
Closed by commit rG532b45fe103c: sound: Create a dsp_close() helper function (authored by christos). · Explain WhyApr 25 2025, 4:57 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG532b45fe103c: sound: Create a dsp_close() helper function.
christos added a reverting change: rG4a556c2277fd: Revert "sound: Create a dsp_close() helper function".Apr 25 2025, 10:04 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
129 lines

Diff 154288

View Options

sys/dev/sound/pcm/dsp.c

Loading...