Page MenuHomeFreeBSD
Differential D28762

ofed: quiet gcc -Wint-in-bool-context
ClosedPublic
Actions

Authored by rlibby on Feb 17 2021, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 9:44 PM
Unknown Object (File)
Sun, Apr 28, 9:53 AM
Unknown Object (File)
Wed, Apr 24, 1:01 AM
Unknown Object (File)
Apr 7 2024, 7:37 PM
Unknown Object (File)
Feb 16 2024, 7:48 PM
Unknown Object (File)
Feb 2 2024, 12:26 PM
Unknown Object (File)
Jan 1 2024, 11:39 AM
Unknown Object (File)
Dec 21 2023, 10:51 PM
View All 36 Files
Subscribers
arichardson
imp

Details

Reviewers
• hselasky
kib
rstone
imp
Commits
rG8f88432a1de0: ofed: quiet gcc -Wint-in-bool-context
rG65d3d8496536: ofed: quiet gcc -Wint-in-bool-context
rGbf667f282a7b: ofed: quiet gcc -Wint-in-bool-context
Summary

The int in the argument to the ternary triggered -Wint-in-bool-context
from gcc. Upstream linux has a larger and more entangled patch,
12f727721eee61b3d19dedb95cb893b2baa9fe41, which doesn't apply cleanly.
When we eventually sync that, we can just drop this change.

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc9 CROSS_TOOLCHAIN=amd64-gcc9 make buildkernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37142
Build 34031: arc lint + arc unit

Event Timeline

rlibby created this revision.Feb 17 2021, 11:33 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 11:33 PM
rlibby requested review of this revision.Feb 17 2021, 11:33 PM
Harbormaster completed remote builds in B37142: Diff 84166.Feb 17 2021, 11:33 PM
imp accepted this revision.Feb 17 2021, 11:53 PM

This is mildly icky, but not terribly so. Since it will be replaced, it's good enough for now. Esp since I can't think of something better to suggest.

This revision is now accepted and ready to land.Feb 17 2021, 11:53 PM
• hselasky accepted this revision.Feb 18 2021, 8:36 AM

Looks good. Don't forget to MFC.

kib accepted this revision.Feb 18 2021, 8:46 AM
Closed by commit rGbf667f282a7b: ofed: quiet gcc -Wint-in-bool-context (authored by rlibby). · Explain WhyFeb 25 2021, 12:01 AM
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rGbf667f282a7b: ofed: quiet gcc -Wint-in-bool-context.
arichardson added a subscriber: arichardson.Jul 2 2021, 5:21 PM

Seems like this is needed to build stable/13 with GCC. Are you going to MFC this? If not I can cherry-pick it for you.

rlibby added a commit: rG65d3d8496536: ofed: quiet gcc -Wint-in-bool-context.Jul 3 2021, 12:28 AM
rlibby added a comment.Jul 3 2021, 1:44 AM
In D28762#697585, @arichardson wrote:

Seems like this is needed to build stable/13 with GCC. Are you going to MFC this? If not I can cherry-pick it for you.

Thanks for the reminder. I did the MFC just now.

It looks like there are a couple other things currently breaking the gcc build in stable/13. It looks like picking eae2ef5a010366c673ad912cae23b426ebb9a8a2 fixes one of them, but not all.

jhb added a commit: rG8f88432a1de0: ofed: quiet gcc -Wint-in-bool-context.Mar 22 2023, 10:30 PM

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
6 lines

Diff 84166

View Options

sys/ofed/drivers/infiniband/core/uverbs.h

Loading...