Page MenuHomeFreeBSD

ofed: quiet gcc -Wint-in-bool-context
ClosedPublic

Authored by rlibby on Feb 17 2021, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 7:48 PM
Unknown Object (File)
Feb 2 2024, 12:26 PM
Unknown Object (File)
Jan 1 2024, 11:39 AM
Unknown Object (File)
Dec 21 2023, 10:51 PM
Unknown Object (File)
Dec 20 2023, 5:59 AM
Unknown Object (File)
Dec 12 2023, 1:08 PM
Unknown Object (File)
Dec 6 2023, 3:19 PM
Unknown Object (File)
Nov 25 2023, 10:05 AM
Subscribers

Details

Summary

The int in the argument to the ternary triggered -Wint-in-bool-context
from gcc. Upstream linux has a larger and more entangled patch,
12f727721eee61b3d19dedb95cb893b2baa9fe41, which doesn't apply cleanly.
When we eventually sync that, we can just drop this change.

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc9 CROSS_TOOLCHAIN=amd64-gcc9 make buildkernel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is mildly icky, but not terribly so. Since it will be replaced, it's good enough for now. Esp since I can't think of something better to suggest.

This revision is now accepted and ready to land.Feb 17 2021, 11:53 PM

Looks good. Don't forget to MFC.

This revision was automatically updated to reflect the committed changes.

Seems like this is needed to build stable/13 with GCC. Are you going to MFC this? If not I can cherry-pick it for you.

Seems like this is needed to build stable/13 with GCC. Are you going to MFC this? If not I can cherry-pick it for you.

Thanks for the reminder. I did the MFC just now.

It looks like there are a couple other things currently breaking the gcc build in stable/13. It looks like picking eae2ef5a010366c673ad912cae23b426ebb9a8a2 fixes one of them, but not all.