Page MenuHomeFreeBSD
Differential D26749

Stop using -O instead of -O2 for MIPS
ClosedPublic
Actions

Authored by arichardson on Oct 12 2020, 12:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 11:22 AM
Unknown Object (File)
Sat, Sep 5, 9:55 AM
Unknown Object (File)
Sat, Sep 5, 7:26 AM
Unknown Object (File)
Fri, Sep 4, 10:02 PM
Unknown Object (File)
Fri, Sep 4, 11:40 AM
Unknown Object (File)
Fri, Sep 4, 4:30 AM
Unknown Object (File)
Thu, Sep 3, 9:35 PM
Unknown Object (File)
Thu, Sep 3, 5:34 AM
View All Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
brooks
jhb
jrtc27
trasz
dim
Commits
rS366664: Stop using -O instead of -O2 for MIPS
Summary

Until clang 11 that was equivalent to -O2, but clang changed it to -O1 so
generated MIPS code will now be unnecessarily slow. It also removes a weird
special case from sys.mk.
This is similar to the D26471 change for debug kernels and should not change
anything since everything was previously building MIPS code at -O2 until clang
was updated to 11.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Oct 12 2020, 12:43 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptOct 12 2020, 12:43 PM
arichardson requested review of this revision.Oct 12 2020, 12:43 PM
Harbormaster completed remote builds in B34112: Diff 78133.Oct 12 2020, 12:43 PM
trasz added inline comments.Oct 12 2020, 3:54 PM
share/mk/sys.mk
166 ↗(On Diff #78133)

And this one?

jrtc27 added inline comments.Oct 12 2020, 3:55 PM
share/mk/sys.mk
166 ↗(On Diff #78133)

POSIX's c89 only gives you -O, -O0 and -O1, with additional levels merely optional.

trasz accepted this revision.Oct 12 2020, 5:27 PM
This revision is now accepted and ready to land.Oct 12 2020, 5:27 PM
Closed by commit rS366664: Stop using -O instead of -O2 for MIPS (authored by arichardson). · Explain WhyOct 13 2020, 8:14 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS366664: Stop using -O instead of -O2 for MIPS.
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2020, 8:14 AM

Revision Contents
Changeset List

PathSize
head/
share/
mk/
4 lines

Diff 78158

View Options

head/share/mk/sys.mk

Loading...