zfs: add to bootloader option to rewind the ZFS checkpoint.
ClosedPublic
Actions

Authored by oshogbo on May 19 2020, 5:08 PM.

Details

Reviewers

allanjude
tsoome
kevans

Commits

rS364355: zfs: add an option to the bootloader to rewind the ZFS checkpoint

Summary

When the checkpoint rewind will be select we will show the BE version
before the checkpoint was made.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31205
Build 28860: arc lint + arc unit

Event Timeline

oshogbo created this revision.May 19 2020, 5:08 PM

Herald added subscribers: bcran, delphij. · View Herald TranscriptMay 19 2020, 5:08 PM

oshogbo requested review of this revision.May 19 2020, 5:08 PM

Harbormaster completed remote builds in B31181: Diff 72000.May 19 2020, 5:08 PM

oshogbo added a reviewer: allanjude.May 19 2020, 5:09 PM

allanjude added reviewers: tsoome, kevans.May 20 2020, 5:51 PM

I'll take a little better look later; I think from a high-level overview it's pretty much how I imagined it should go.

stand/lua/menu.lua
144	I don't think we actually want this change. =-)

Typo pointed by @kevans. Thanks!

Harbormaster completed remote builds in B31205: Diff 72038.May 20 2020, 6:22 PM

Reviewed By: allanjude

This revision is now accepted and ready to land.May 21 2020, 1:45 AM

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

In D24920#549047, @tsoome wrote:

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

In D24920#549167, @oshogbo wrote:

In D24920#549047, @tsoome wrote:

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

If you do not feel too comfortable about docs, probably someone can help out:)

I can not tell much about lua bits, but the rest seems good. I was starting to think if using ! is complicating things (could just use environment variable - those are accessible via kenv), but I'm all good.

tsoome added inline comments.May 27 2020, 8:15 PM