Page MenuHomeFreeBSD

zfs: add to bootloader option to rewind the ZFS checkpoint.
ClosedPublic

Authored by oshogbo on May 19 2020, 5:08 PM.

Details

Summary

When the checkpoint rewind will be select we will show the BE version
before the checkpoint was made.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I'll take a little better look later; I think from a high-level overview it's pretty much how I imagined it should go.

stand/lua/menu.lua
144 ↗(On Diff #72000)

I don't think we actually want this change. =-)

This revision is now accepted and ready to land.May 21 2020, 1:45 AM

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

If you do not feel too comfortable about docs, probably someone can help out:)

I can not tell much about lua bits, but the rest seems good. I was starting to think if using ! is complicating things (could just use environment variable - those are accessible via kenv), but I'm all good.

sys/cddl/boot/zfs/zfsimpl.h
1801 ↗(On Diff #72038)

Copy'n'paste error?

@oshogbo The kmod changes are going to be overwritten by this weeks merge, so it would probably be worthwhile to create a PR upstream. Thanks.