Page MenuHomeFreeBSD

zfs: add to bootloader option to rewind the ZFS checkpoint.
AcceptedPublic

Authored by oshogbo on Tue, May 19, 5:08 PM.

Details

Summary

When the checkpoint rewind will be select we will show the BE version
before the checkpoint was made.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 31205
Build 28860: arc lint + arc unit

Event Timeline

oshogbo created this revision.Tue, May 19, 5:08 PM
oshogbo requested review of this revision.Tue, May 19, 5:08 PM

I'll take a little better look later; I think from a high-level overview it's pretty much how I imagined it should go.

stand/lua/menu.lua
144

I don't think we actually want this change. =-)

oshogbo updated this revision to Diff 72038.Wed, May 20, 6:22 PM

Typo pointed by @kevans. Thanks!

allanjude accepted this revision.Thu, May 21, 1:45 AM

Reviewed By: allanjude

This revision is now accepted and ready to land.Thu, May 21, 1:45 AM

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

In general, it seems nice. I'd like to see more for description; how the checkpoints would appear, what it means to the boot process, would it mean updates for some manual/handbook? It would nice to refer to zpool, not all people do know where to look for information.

It will appear only if you will if you have checkpoint in the system.
This is small demo: https://youtu.be/Flor6seU080
Please ignore some debug info I already removed them.
Yea probably it is good to update the handbook as well.
I'm never edited the handbook though.

If you do not feel too comfortable about docs, probably someone can help out:)

tsoome accepted this revision.Thu, May 21, 5:40 PM

I can not tell much about lua bits, but the rest seems good. I was starting to think if using ! is complicating things (could just use environment variable - those are accessible via kenv), but I'm all good.