Page MenuHomeFreeBSD

Introduce a driver for NXP LS10xx SoC AHCI.
ClosedPublic

Authored by dgr_semihalf.com on Apr 17 2020, 11:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 7:28 PM
Unknown Object (File)
Oct 24 2024, 2:58 AM
Unknown Object (File)
Oct 3 2024, 1:06 PM
Unknown Object (File)
Oct 3 2024, 11:35 AM
Unknown Object (File)
Sep 28 2024, 4:05 AM
Unknown Object (File)
Sep 28 2024, 4:02 AM
Unknown Object (File)
Sep 25 2024, 10:48 AM
Unknown Object (File)
Sep 25 2024, 10:43 AM
Subscribers

Details

Summary

Implement support for AHCI controller found in
NXP QorIQ Layerscape SoCs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Do you know how different this controller is compared to the other fsl ahci controller ? (like ls208x etc ...)
If it's very different the file should be renamed.

Add dependency on SOC_NXP_LS1046A option.

In D24466#538161, @manu wrote:

Do you know how different this controller is compared to the other fsl ahci controller ? (like ls208x etc ...)
If it's very different the file should be renamed.

I checked and while there will be some modifications needed, I think that most of the code can be shared.

There is no clock enabling here but the dtsi have a clock property.

sys/dev/ahci/ahci_fsl_fdt.c
5

I don't know if your client requires it but it's been deprecated in FreeBSD.

The controller is actually connected to platform PLL, which
is always enabled, but since the controller might be used in
different SoC in the future, I'll add clock enabling.

sys/dev/ahci/ahci_fsl_fdt.c
5

I will remove it.

Removed "All rights reserved" from copyright notice.
Added clock enabling in attach function.

Hi, if you have any more comments or remarks, please let me know. Thanks.

This revision is now accepted and ready to land.May 15 2020, 10:08 AM

Replace SOC_NXP_LS1046 with SOC_NXP_LS.

This revision now requires review to proceed.May 22 2020, 8:09 PM
This revision is now accepted and ready to land.May 22 2020, 8:31 PM
This revision was automatically updated to reflect the committed changes.