bridge: Change lists to CK_LIST as a peparation for epochification
ClosedPublic
Actions

Authored by kp on Apr 1 2020, 2:26 PM.

Details

Reviewers

emaste
philip
ae

Group Reviewers

network

Commits

rS359641: bridge: Change lists to CK_LIST as a peparation for epochification

Summary

Prepare the ground for a rework of the bridge locking approach. We will
use an epoch-based approach in the datapath and making it safe to
iterate over the interface, span and rtnode lists without holding the
BRIDGE_LOCK. Replace the relevant lists by their ConcurrencyKit
equivalents.

No functional change in this commit.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Apr 1 2020, 2:26 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptApr 1 2020, 2:26 PM

Harbormaster completed remote builds in B30228: Diff 70090.Apr 1 2020, 2:26 PM

kp added a child revision: D24250: bridge: epoch-ification.Apr 1 2020, 2:27 PM

afedorov added a subscriber: afedorov.Apr 1 2020, 4:35 PM

emaste added inline comments.Apr 1 2020, 9:35 PM

sys/net/if_bridge.c
1088 ↗	(On Diff #70090)	> 80 cols?

philip added inline comments.Apr 2 2020, 2:15 AM

sys/net/if_bridge.c
280 ↗	(On Diff #70090)	Does this belong in this review? It doesn't appear to be referenced by other changes in this diff.

Fix style issue and remove stray epoch_ctx.

Harbormaster completed remote builds in B30239: Diff 70109.Apr 2 2020, 8:24 AM

kp marked 2 inline comments as done.Apr 2 2020, 8:25 AM

kp added inline comments.

sys/net/if_bridge.c
280 ↗	(On Diff #70090)	It does not. I've removed it.

ae accepted this revision.Apr 2 2020, 8:40 AM

This revision is now accepted and ready to land.Apr 2 2020, 8:40 AM

crest_bultmann.eu added a subscriber: crest_bultmann.eu.Apr 2 2020, 10:02 AM

OK with me

emaste accepted this revision.Apr 4 2020, 5:41 PM

Closed by commit rS359641: bridge: Change lists to CK_LIST as a peparation for epochification (authored by kp). · Explain WhyApr 5 2020, 5:16 PM

This revision was automatically updated to reflect the committed changes.

kp marked an inline comment as done.

kp added a commit: rS359641: bridge: Change lists to CK_LIST as a peparation for epochification.

Herald added a subscriber: imp. · View Herald TranscriptApr 5 2020, 5:16 PM

Here are my result:

x r359647 in bridge mode: inet 4 packets forwarded per second
+ r359647 with D24250 in bridge mode: inet 4 packets forwarded per second
+--------------------------------------------------------------------------+
|xx                                                                      + |
|xx                                                                 +  + ++|
|A|                                                                        |
|                                                                     |_AM||
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5       3314595       3582601       3450403       3448858     99435.922
+   5      22726995      24346441      23963008      23715416     617156.45
Difference at 95.0% confidence
        2.02666e+07 +/- 644666
        587.631% +/- 27.5422%
        (Student's t, pooled s = 442024)

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_bridge.c

130 lines

Diff 70231

View Options

bridge: Change lists to CK_LIST as a peparation for epochificationClosedPublicActions