bhyve: Initial some NVMe controller health log data.
ClosedPublic
Actions

Authored by wanpengqian_gmail.com on Mar 27 2020, 12:49 PM.

Details

Reviewers

chuck
wanpengqian_gmail.com
jhb
grehan

Group Reviewers

bhyve

Commits

rS364602: bhyve: NVMe set nominal health values

Summary

Currently, bhyve NVMe controller does not set logpage health data. For some OSs, they think NVMe device is falling without reasonable values.

These fields are:

Temperature
Available spare
Available spare threshold

This patch will set some reasonable values.

Test Plan

From guest, check these values.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wanpengqian_gmail.com created this revision.Mar 27 2020, 12:49 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 27 2020, 12:49 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

Harbormaster completed remote builds in B30132: Diff 69916.Mar 27 2020, 12:49 PM

wanpengqian_gmail.com edited the summary of this revision. (Show Details)Mar 27 2020, 12:58 PM

Should have a better way to initial health log.

This looks good to me. Please rebase against the latest and I'd be happy to commit this.

usr.sbin/bhyve/pci_nvme.c
452 ↗	(On Diff #69916)	Per `style(9)` this white space should remain.
455 ↗	(On Diff #69916)	Perhaps, reword as `/* Set nominal Health values checked by implementations */`

chuck added a reviewer: chuck.Aug 1 2020, 1:49 PM

chuck mentioned this in D25876: bhyve: Passthrough host's NVMe device health logpage to guests..Aug 1 2020, 2:45 PM

Update code sytle and comments.

Harbormaster completed remote builds in B32699: Diff 75259.Aug 2 2020, 12:03 AM

Thank you chuck.
I am bring back and update this patch as your comments.

wanpengqian_gmail.com marked 2 inline comments as done.Aug 2 2020, 1:15 AM

Looks good. Thank you for contributing this!

This revision is now accepted and ready to land.Aug 2 2020, 9:53 PM

I am sorry, I am new to this review system.
@chuck Do I need to do any action now or just wait?

From this page FreeBSD Wiki: Phabricator, I should commit this by myself

Once the reviewers are happy with your change, they will accept your patch (which will be denoted by a green tick on the web site). At this point, you are free to submit the change to svn. Just use svn commit as usual.

But I don't think I have permission for this.