Page MenuHomeFreeBSD

bhyve: Initial some NVMe controller health log data.
ClosedPublic

Authored by wanpengqian_gmail.com on Mar 27 2020, 12:49 PM.

Details

Summary

Currently, bhyve NVMe controller does not set logpage health data. For some OSs, they think NVMe device is falling without reasonable values.

These fields are:

Temperature
Available spare
Available spare threshold

This patch will set some reasonable values.

Test Plan

From guest, check these values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Should have a better way to initial health log.

This looks good to me. Please rebase against the latest and I'd be happy to commit this.

usr.sbin/bhyve/pci_nvme.c
452 ↗(On Diff #69916)

Per style(9) this white space should remain.

455 ↗(On Diff #69916)

Perhaps, reword as

/* Set nominal Health values checked by implementations */

Thank you chuck.
I am bring back and update this patch as your comments.

Looks good. Thank you for contributing this!

This revision is now accepted and ready to land.Aug 2 2020, 9:53 PM

I am sorry, I am new to this review system.
@chuck Do I need to do any action now or just wait?

From this page FreeBSD Wiki: Phabricator, I should commit this by myself

Once the reviewers are happy with your change, they will accept your patch (which will be denoted by a green tick on the web site). At this point, you are free to submit the change to svn. Just use svn commit as usual.

But I don't think I have permission for this.

I'm happy with this change but need to wait for maintainer approval before I commit it

I'm happy with this change but need to wait for maintainer approval before I commit it

I'm good with it if you're good with it :)

This revision was automatically updated to reflect the committed changes.