Page MenuHomeFreeBSD

bhyve: Initial some NVMe controller health log data.
AcceptedPublic

Authored by wanpengqian_gmail.com on Mar 27 2020, 12:49 PM.

Details

Reviewers
chuck
Group Reviewers
bhyve
Summary

Currently, bhyve NVMe controller does not set logpage health data. For some OSs, they think NVMe device is falling without reasonable values.

These fields are:

Temperature
Available spare
Available spare threshold

This patch will set some reasonable values.

Test Plan

From guest, check these values.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 32699
Build 30146: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com edited the summary of this revision. (Show Details)Mar 27 2020, 12:58 PM

Should have a better way to initial health log.

chuck added a subscriber: chuck.Sat, Aug 1, 1:48 PM

This looks good to me. Please rebase against the latest and I'd be happy to commit this.

usr.sbin/bhyve/pci_nvme.c
452

Per style(9) this white space should remain.

456

Perhaps, reword as

/* Set nominal Health values checked by implementations */

chuck added a reviewer: chuck.Sat, Aug 1, 1:49 PM

Update code sytle and comments.

Thank you chuck.
I am bring back and update this patch as your comments.

wanpengqian_gmail.com marked 2 inline comments as done.Sun, Aug 2, 1:15 AM
chuck accepted this revision as: chuck.Sun, Aug 2, 9:53 PM

Looks good. Thank you for contributing this!

This revision is now accepted and ready to land.Sun, Aug 2, 9:53 PM