Page MenuHomeFreeBSD

Enable ixl device on PowerPC64
ClosedPublic

Authored by luporl on Mar 5 2020, 4:57 PM.
Referenced Files
F103256141: D23974.diff
Fri, Nov 22, 5:07 PM
Unknown Object (File)
Oct 13 2024, 5:18 PM
Unknown Object (File)
Sep 27 2024, 8:11 AM
Unknown Object (File)
Sep 23 2024, 2:36 PM
Unknown Object (File)
Sep 20 2024, 11:03 PM
Unknown Object (File)
Sep 20 2024, 12:35 PM
Unknown Object (File)
Sep 20 2024, 5:12 AM
Unknown Object (File)
Sep 19 2024, 1:06 PM

Details

Summary

With D23975, ixl driver now works on PowerPC64 and may be compiled in-kernel and as a module.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

luporl added a reviewer: erj.
luporl added a project: PowerPC.
erj requested changes to this revision.Mar 5 2020, 7:30 PM

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

This revision now requires changes to proceed.Mar 5 2020, 7:30 PM
luporl retitled this revision from Make ixl device available to all arches to Enable ixl device on PowerPC64.
luporl edited the summary of this revision. (Show Details)
luporl added a reviewer: PowerPC.
  • Make ixl device available only on amd64 and PowerPC64
  • Enable ixl by default on PowerPC64
In D23974#527044, @erj wrote:

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

Ok, enabling it only on PowerPC64 is fine with me.

Looks good to me. Nice job fixing it in powerpc64!

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

This revision is now accepted and ready to land.Mar 12 2020, 12:23 AM
In D23974#528509, @erj wrote:

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

Ok, I understand. We have a PowerPC64 machine with a X710 NIC that is now using this driver and that some PPC developers will be using, so hopefully we'll be able to test the driver and report/fix issues and regressions, although we use only basic networking functionality.

This revision was automatically updated to reflect the committed changes.