Enable ixl device on PowerPC64
ClosedPublic
Actions

Authored by luporl on Mar 5 2020, 4:57 PM.

Details

Reviewers

erj
alfredo

Group Reviewers

PowerPC

Commits

rS358908: Enable ixl device on PowerPC64

Summary

With D23975, ixl driver now works on PowerPC64 and may be compiled in-kernel and as a module.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29808
Build 27636: arc lint + arc unit

Event Timeline

luporl created this revision.Mar 5 2020, 4:57 PM

Harbormaster completed remote builds in B29808: Diff 69228.Mar 5 2020, 4:57 PM

luporl edited the summary of this revision. (Show Details)Mar 5 2020, 6:05 PM

luporl added a reviewer: erj.

luporl added a project: PowerPC.

Herald added subscribers: alfredo, bdragon. · View Herald TranscriptMar 5 2020, 6:05 PM

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

This revision now requires changes to proceed.Mar 5 2020, 7:30 PM

Make ixl device available only on amd64 and PowerPC64
Enable ixl by default on PowerPC64

Herald added a subscriber: jhibbits. · View Herald TranscriptMar 6 2020, 2:37 PM

Harbormaster completed remote builds in B29826: Diff 69266.Mar 6 2020, 2:37 PM

In D23974#527044, @erj wrote:

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

Ok, enabling it only on PowerPC64 is fine with me.

Looks good to me. Nice job fixing it in powerpc64!

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

This revision is now accepted and ready to land.Mar 12 2020, 12:23 AM

In D23974#528509, @erj wrote:

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

Ok, I understand. We have a PowerPC64 machine with a X710 NIC that is now using this driver and that some PPC developers will be using, so hopefully we'll be able to test the driver and report/fix issues and regressions, although we use only basic networking functionality.

Closed by commit rS358908: Enable ixl device on PowerPC64 (authored by luporl). · Explain WhyMar 12 2020, 12:47 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS358908: Enable ixl device on PowerPC64.

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2020, 12:47 PM