Page MenuHomeFreeBSD
Differential D23974

Enable ixl device on PowerPC64
ClosedPublic
Actions

Authored by luporl on Mar 5 2020, 4:57 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Mar 31, 7:25 AM
Unknown Object (File)
Fri, Mar 22, 6:09 PM
Unknown Object (File)
Fri, Mar 22, 6:08 PM
Unknown Object (File)
Fri, Mar 22, 6:08 PM
Unknown Object (File)
Fri, Mar 22, 6:08 PM
Unknown Object (File)
Fri, Mar 22, 5:47 PM
Unknown Object (File)
Feb 8 2024, 9:59 PM
Unknown Object (File)
Dec 20 2023, 7:34 AM
View All 29 Files
Subscribers
alfredo
bdragon
imp
jhibbits

Details

Reviewers
erj
alfredo
Group Reviewers
PowerPC
Commits
rS358908: Enable ixl device on PowerPC64
Summary

With D23975, ixl driver now works on PowerPC64 and may be compiled in-kernel and as a module.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

luporl created this revision.Mar 5 2020, 4:57 PM
Harbormaster completed remote builds in B29808: Diff 69228.Mar 5 2020, 4:57 PM
luporl edited the summary of this revision. (Show Details)Mar 5 2020, 6:05 PM
luporl added a reviewer: erj.
luporl added a project: PowerPC.
Herald added subscribers: alfredo, bdragon. · View Herald TranscriptMar 5 2020, 6:05 PM
erj requested changes to this revision.Mar 5 2020, 7:30 PM

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

This revision now requires changes to proceed.Mar 5 2020, 7:30 PM
luporl updated this revision to Diff 69266.Mar 6 2020, 2:37 PM
luporl retitled this revision from Make ixl device available to all arches to Enable ixl device on PowerPC64.
luporl edited the summary of this revision. (Show Details)
luporl added a reviewer: PowerPC.
  • Make ixl device available only on amd64 and PowerPC64
  • Enable ixl by default on PowerPC64
Herald added a subscriber: jhibbits. · View Herald TranscriptMar 6 2020, 2:37 PM
Harbormaster completed remote builds in B29826: Diff 69266.Mar 6 2020, 2:37 PM
luporl added a comment.Mar 6 2020, 2:38 PM
In D23974#527044, @erj wrote:

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

Ok, enabling it only on PowerPC64 is fine with me.

alfredo accepted this revision as: alfredo.Mar 6 2020, 5:17 PM

Looks good to me. Nice job fixing it in powerpc64!

erj accepted this revision.Mar 12 2020, 12:23 AM

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

This revision is now accepted and ready to land.Mar 12 2020, 12:23 AM
luporl added a comment.Mar 12 2020, 12:39 PM
In D23974#528509, @erj wrote:

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

Ok, I understand. We have a PowerPC64 machine with a X710 NIC that is now using this driver and that some PPC developers will be using, so hopefully we'll be able to test the driver and report/fix issues and regressions, although we use only basic networking functionality.

Closed by commit rS358908: Enable ixl device on PowerPC64 (authored by luporl). · Explain WhyMar 12 2020, 12:47 PM
This revision was automatically updated to reflect the committed changes.
luporl added a commit: rS358908: Enable ixl device on PowerPC64.
Herald added a subscriber: imp. · View Herald TranscriptMar 12 2020, 12:47 PM

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
37 lines
2 lines
modules/
1 line
powerpc/
conf/
1 line

Diff 69422

View Options

head/sys/conf/files.powerpc

Loading...
View Options

head/sys/conf/options.powerpc

Loading...
View Options

head/sys/modules/Makefile

Loading...
View Options

head/sys/powerpc/conf/GENERIC64

Loading...