ixl: Add missing conversions from/to LE16
ClosedPublic
Actions

Authored by luporl on Mar 5 2020, 5:05 PM.

Details

Reviewers

sbruno
erj

Commits

rS358698: ixl: Add missing conversions from/to LE16

Summary

This fixes some errors on PPC64, during attach and when trying to assign an IP to an interface.
With this change, basic operation of X710 NICs is now possible.

This also fixes builds with IXL_DEBUG enabled

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

luporl created this revision.Mar 5 2020, 5:05 PM

Herald added a subscriber: ae. · View Herald TranscriptMar 5 2020, 5:05 PM

Harbormaster completed remote builds in B29809: Diff 69229.Mar 5 2020, 5:05 PM

luporl retitled this revision from ixl: Add missing CPU_TO_LE16 conversions to ixl: Add missing conversions from/to LE16.Mar 5 2020, 5:07 PM

luporl mentioned this in D23974: Enable ixl device on PowerPC64.Mar 5 2020, 6:05 PM

luporl added reviewers: sbruno, erj.Mar 5 2020, 6:09 PM

luporl added a project: PowerPC.

Herald added subscribers: alfredo, bdragon. · View Herald TranscriptMar 5 2020, 6:09 PM

Thanks for fixing the issue with IXL_DEBUG! The CPU_TO_LE16 changes look acceptable to me, but we can't guarantee we'll be vigilant about adding them to new code in the future since we only officially support amd64 for ixl.

This revision is now accepted and ready to land.Mar 5 2020, 7:18 PM

Closed by commit rS358698: ixl: Add missing conversions from/to LE16 (authored by luporl). · Explain WhyMar 6 2020, 12:37 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS358698: ixl: Add missing conversions from/to LE16.

Herald added a subscriber: imp. · View Herald TranscriptMar 6 2020, 12:37 PM