Page MenuHomeFreeBSD

Fix panics when using iflib pseudo device support
AcceptedPublic

Authored by mmacy on Feb 16 2020, 2:02 AM.

Details

Reviewers
hselasky
jhb
shurd
gallatin
Group Reviewers
iflib
Summary
  • _iflib_assert checks for values that are only relevant when doing queue management
  • iflib_pseudo_register can return without dropping the context sx lock
Test Plan

ifconfig wg create with the fixes

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mmacy created this revision.Feb 16 2020, 2:02 AM

Can you upload patch context?

mmacy updated this revision to Diff 68429.Feb 16 2020, 10:41 PM
hselasky accepted this revision.Feb 16 2020, 10:57 PM
gallatin accepted this revision.Feb 18 2020, 2:31 PM
gallatin added a subscriber: gallatin.

I'd prefer the check be moved inside _iflib_assert(), but that's just a nit.

This revision is now accepted and ready to land.Feb 18 2020, 2:31 PM

Are there any objections to not committing this?

No objections. Maybe split the commit into two when upstreaming and write a good commit message and don't forget to MFC.

I have further changes.