Page MenuHomeFreeBSD

Fix panics when using iflib pseudo device support
ClosedPublic

Authored by mmacy on Feb 16 2020, 2:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 6:33 AM
Unknown Object (File)
Sat, Sep 27, 1:38 AM
Unknown Object (File)
Sat, Sep 20, 2:29 PM
Unknown Object (File)
Sep 13 2025, 4:56 PM
Unknown Object (File)
Sep 6 2025, 9:38 AM
Unknown Object (File)
Aug 31 2025, 9:51 PM
Unknown Object (File)
Aug 10 2025, 4:35 AM
Unknown Object (File)
Aug 3 2025, 3:04 PM

Details

Summary
  • _iflib_assert checks for values that are only relevant when doing queue management
  • iflib_pseudo_register can return without dropping the context sx lock
Test Plan

ifconfig wg create with the fixes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gallatin added a subscriber: gallatin.

I'd prefer the check be moved inside _iflib_assert(), but that's just a nit.

This revision is now accepted and ready to land.Feb 18 2020, 2:31 PM

Are there any objections to not committing this?

No objections. Maybe split the commit into two when upstreaming and write a good commit message and don't forget to MFC.

This revision was automatically updated to reflect the committed changes.