Page MenuHomeFreeBSD

Fix panics when using iflib pseudo device support
ClosedPublic

Authored by mmacy on Feb 16 2020, 2:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 21, 4:26 AM
Unknown Object (File)
Sun, Dec 14, 12:38 PM
Unknown Object (File)
Fri, Nov 28, 2:49 AM
Unknown Object (File)
Tue, Nov 25, 1:23 PM
Unknown Object (File)
Sun, Nov 23, 11:22 PM
Unknown Object (File)
Sun, Nov 23, 1:17 AM
Unknown Object (File)
Sat, Nov 22, 9:39 PM
Unknown Object (File)
Nov 21 2025, 2:28 PM

Details

Summary
  • _iflib_assert checks for values that are only relevant when doing queue management
  • iflib_pseudo_register can return without dropping the context sx lock
Test Plan

ifconfig wg create with the fixes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gallatin added a subscriber: gallatin.

I'd prefer the check be moved inside _iflib_assert(), but that's just a nit.

This revision is now accepted and ready to land.Feb 18 2020, 2:31 PM

Are there any objections to not committing this?

No objections. Maybe split the commit into two when upstreaming and write a good commit message and don't forget to MFC.

This revision was automatically updated to reflect the committed changes.