Page MenuHomeFreeBSD

[New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages
AcceptedPublic

Authored by dteske on Dec 4 2019, 5:09 PM.

Details

Reviewers
imp
swills
mat
Summary

bigmemory.sri provides a shared resource interface for the bigmemory
and synchronicity packages in R.

Test Plan

install, deinstall, package, pkg install, pkg delete

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27955
Build 26121: arc lint + arc unit

Event Timeline

This looks generally good to me, modulo my one comment. I assume that it also passes portlint since I didn't do that myself.

devel/Makefile
20 ↗(On Diff #65216)

Are these updated when ports are added, or is there automation that keeps it up to date?

devel/Makefile
20 ↗(On Diff #65216)

Tools/scripts/addport automatically adds it.

But, I want the review to reflect the addition before running Tools/scripts/addport (which would, ahem, commit the port without going to review first)

EDIT: If you would prefer me to not put these changes in the reviews, I'm OK with that

Drop Makefile change from review (done by addport)

assuming it passed portlint and this was part of a poudriere build, it looks ready.

This revision is now accepted and ready to land.Dec 4 2019, 6:51 PM
This revision now requires review to proceed.Dec 4 2019, 6:52 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:00 PM
This revision now requires review to proceed.Dec 4 2019, 8:23 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:32 PM