bigmemory.sri provides a shared resource interface for the bigmemory
and synchronicity packages in R.
Details
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
This looks generally good to me, modulo my one comment. I assume that it also passes portlint since I didn't do that myself.
| devel/Makefile | ||
|---|---|---|
| 21 | Are these updated when ports are added, or is there automation that keeps it up to date? | |
| devel/Makefile | ||
|---|---|---|
| 21 | Tools/scripts/addport automatically adds it. But, I want the review to reflect the addition before running Tools/scripts/addport (which would, ahem, commit the port without going to review first) EDIT: If you would prefer me to not put these changes in the reviews, I'm OK with that | |
Refresh against current ports tree and CRAN bigmemory.sri 0.1.8 (was 0.1.3).
Since @mat's accept in 2019:
- bump to 0.1.8
- modern Makefile (WWW=, drop $FreeBSD$; COMMENT without leading "A")
- add devel/Makefile SUBDIR
Tested with DEVELOPER=yes: makesum, stage, stage-qa (clean), package.
@mat: would you mind re-accepting when you have a moment?
| devel/R-cran-bigmemory.sri/pkg-descr | ||
|---|---|---|
| 3 | That's all CRAN provides us with though. I ran portlint (with -A) and it said that it looked fine. What options are you passing? | |
LGTM and approved for commit.
| devel/R-cran-bigmemory.sri/pkg-descr | ||
|---|---|---|
| 3 | I checked the portlint script again and it seems like the check has been relaxed recently. So don't worry about it. | |
| devel/R-cran-bigmemory.sri/pkg-descr | ||
|---|---|---|
| 3 | 👍 | |