Page MenuHomeFreeBSD

devel/R-cran-bigmemory.sri: New port
ClosedPublic

Authored by dteske on Dec 4 2019, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 10, 1:16 AM
Unknown Object (File)
Fri, Oct 9, 6:55 PM
Unknown Object (File)
Wed, Oct 7, 11:58 AM
Unknown Object (File)
Sat, Oct 3, 8:16 AM
Unknown Object (File)
Thu, Oct 1, 11:09 AM
Unknown Object (File)
Tue, Sep 29, 5:43 AM
Unknown Object (File)
Mon, Sep 28, 4:16 PM
Unknown Object (File)
Mon, Sep 28, 7:52 AM
Subscribers

Details

Summary

bigmemory.sri provides a shared resource interface for the bigmemory
and synchronicity packages in R.

Test Plan

install, deinstall, package, pkg install, pkg delete

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks generally good to me, modulo my one comment. I assume that it also passes portlint since I didn't do that myself.

devel/Makefile
21

Are these updated when ports are added, or is there automation that keeps it up to date?

devel/Makefile
21

Tools/scripts/addport automatically adds it.

But, I want the review to reflect the addition before running Tools/scripts/addport (which would, ahem, commit the port without going to review first)

EDIT: If you would prefer me to not put these changes in the reviews, I'm OK with that

Drop Makefile change from review (done by addport)

assuming it passed portlint and this was part of a poudriere build, it looks ready.

This revision is now accepted and ready to land.Dec 4 2019, 6:51 PM
This revision now requires review to proceed.Dec 4 2019, 6:52 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:00 PM
This revision now requires review to proceed.Dec 4 2019, 8:23 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:32 PM
dteske retitled this revision from [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages to devel/R-cran-bigmemory.sri: New port.Jul 29 2026, 1:19 AM

Refresh against current ports tree and CRAN bigmemory.sri 0.1.8 (was 0.1.3).

Since @mat's accept in 2019:

  • bump to 0.1.8
  • modern Makefile (WWW=, drop $FreeBSD$; COMMENT without leading "A")
  • add devel/Makefile SUBDIR

Tested with DEVELOPER=yes: makesum, stage, stage-qa (clean), package.

@mat: would you mind re-accepting when you have a moment?

This revision now requires review to proceed.Jul 29 2026, 1:20 AM
devel/R-cran-bigmemory.sri/Makefile
3

Please use DISTVERSION if possible.

devel/R-cran-bigmemory.sri/pkg-descr
3

pkg-descr should be at least three lines (portlint).

devel/R-cran-bigmemory.sri/pkg-descr
3

That's all CRAN provides us with though. I ran portlint (with -A) and it said that it looked fine. What options are you passing?

Use DISTVERSION, sort LICENSE, remove WWW (use cran.mk default)

LGTM and approved for commit.

devel/R-cran-bigmemory.sri/pkg-descr
3

I checked the portlint script again and it seems like the check has been relaxed recently. So don't worry about it.

This revision is now accepted and ready to land.Sun, Sep 27, 9:22 AM
dteske added inline comments.
devel/R-cran-bigmemory.sri/pkg-descr
3

👍

This revision was automatically updated to reflect the committed changes.
dteske marked an inline comment as done.