Page MenuHomeFreeBSD
Differential D22676

devel/R-cran-bigmemory.sri: New port
Needs ReviewPublic
Actions

Authored by dteske on Dec 4 2019, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 2, 10:10 AM
Unknown Object (File)
Sun, Aug 2, 4:40 AM
Unknown Object (File)
Sat, Aug 1, 5:39 PM
Unknown Object (File)
Sat, Aug 1, 5:05 PM
Unknown Object (File)
Sat, Aug 1, 3:51 PM
Unknown Object (File)
Sat, Aug 1, 5:16 AM
Unknown Object (File)
Sat, Aug 1, 1:38 AM
Unknown Object (File)
Fri, Jul 31, 7:19 PM
View All Files
Subscribers
adamw

Details

Reviewers
imp
swills
mat
Summary

bigmemory.sri provides a shared resource interface for the bigmemory
and synchronicity packages in R.

Test Plan

install, deinstall, package, pkg install, pkg delete

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27955
Build 26121: arc lint + arc unit

Event Timeline

dteske created this revision.Dec 4 2019, 5:09 PM
Harbormaster completed remote builds in B27944: Diff 65216.Dec 4 2019, 5:09 PM
imp added a comment.Dec 4 2019, 5:17 PM

This looks generally good to me, modulo my one comment. I assume that it also passes portlint since I didn't do that myself.

devel/Makefile
20 ↗(On Diff #65216)

Are these updated when ports are added, or is there automation that keeps it up to date?

dteske added inline comments.Dec 4 2019, 5:30 PM
devel/Makefile
20 ↗(On Diff #65216)

Tools/scripts/addport automatically adds it.

But, I want the review to reflect the addition before running Tools/scripts/addport (which would, ahem, commit the port without going to review first)

EDIT: If you would prefer me to not put these changes in the reviews, I'm OK with that

dteske updated this revision to Diff 65225.Dec 4 2019, 6:29 PM

Drop Makefile change from review (done by addport)

Harbormaster completed remote builds in B27951: Diff 65225.Dec 4 2019, 6:29 PM
imp accepted this revision.Dec 4 2019, 6:51 PM

assuming it passed portlint and this was part of a poudriere build, it looks ready.

This revision is now accepted and ready to land.Dec 4 2019, 6:51 PM
dteske updated this revision to Diff 65230.Dec 4 2019, 6:52 PM

Remove extra newline

This revision now requires review to proceed.Dec 4 2019, 6:52 PM
Harbormaster completed remote builds in B27955: Diff 65230.Dec 4 2019, 6:52 PM
mat accepted this revision.Dec 4 2019, 8:00 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:00 PM
dteske removed a reviewer: mat.Dec 4 2019, 8:23 PM
This revision now requires review to proceed.Dec 4 2019, 8:23 PM
mat accepted this revision.Dec 4 2019, 8:32 PM
This revision is now accepted and ready to land.Dec 4 2019, 8:32 PM
dteske retitled this revision from [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages to devel/R-cran-bigmemory.sri: New port.Wed, Jul 29, 1:19 AM
dteske updated this revision to Diff 183011.Wed, Jul 29, 1:20 AM

Refresh against current ports tree and CRAN bigmemory.sri 0.1.8 (was 0.1.3).

Since @mat's accept in 2019:

  • bump to 0.1.8
  • modern Makefile (WWW=, drop $FreeBSD$; COMMENT without leading "A")
  • add devel/Makefile SUBDIR

Tested with DEVELOPER=yes: makesum, stage, stage-qa (clean), package.

@mat: would you mind re-accepting when you have a moment?

This revision now requires review to proceed.Wed, Jul 29, 1:20 AM
Harbormaster completed remote builds in B75253: Diff 183011.Wed, Jul 29, 1:20 AM
dteske mentioned this in D22677: devel/R-cran-bigmemory: New port.Wed, Jul 29, 1:25 AM

Revision Contents
Changeset List

PathSize
devel/
R-cran-bigmemory.sri/
17 lines
3 lines
4 lines

Diff 65230

View Options

devel/R-cran-bigmemory.sri/

Loading...
View Options

devel/R-cran-bigmemory.sri/Makefile

Loading...
View Options

devel/R-cran-bigmemory.sri/distinfo

Loading...
View Options

devel/R-cran-bigmemory.sri/pkg-descr

Loading...